Fixed null reference in WMSGetFeatureInfo on Internet Explorer 11 #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontent-type of the response is 'application/json'. In the case that JSON is returned, the features array is constructed by parsing doc with OpenLayers.Format.GeoJSON. This prevents a null reference issue when asking for feature information from GeoServer on Internet Explorer 11.
| @@ -517,8 +526,9 @@ OpenLayers.Control.WMSGetFeatureInfo = OpenLayers.Class(OpenLayers.Control, { | |||
| {url: url, features: features} | |||
| ); | |||
| } else { | |||
| this._features = (this._features || []).concat(features); | |||
| this._features = (this._features || []).concat(features); | |||
|
Looks good. Please address the two minor comments. Do we have a CLA from you? If not, please submit one so we can merge this. See https://github.com/openlayers/cla. |
|
Sorry for the late response. I finally got a CCLA signed by my boss. The list should have received an email from my boss, Scott Eckersall, with the CCLA. |
|
CCLA received. Thanks! |
ahocevar
added a commit
that referenced
this pull request
Sep 6, 2014
…uashed Fixed null reference in WMSGetFeatureInfo on Internet Explorer 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a small issue with the WMSGetFeatureInfo today. If I set the infoFormat option to 'application/json', then I end up with a null reference exception in format.read on Internet Explorer 11. I thought that it might be better to have the handleResponse method check the content type of the response (and the type in infoFormat) to determine if the response is 'application/json'. In the case that the response is 'application/json', parse the responseText using OpenLayers.Format.GeoJSON.
I have added this logic to the handleResponse method, and added an appropriate test case to the test harness. Also, this is only my second contribution to an open source project, and my first pull request on GitHub, so any constructive criticism would be greatly appreciated.