Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: raise UpdaterError if LVC is not valid #540

Closed
wants to merge 2 commits into from
Closed

fix: raise UpdaterError if LVC is not valid #540

wants to merge 2 commits into from

Conversation

n-dusan
Copy link
Contributor

@n-dusan n-dusan commented Sep 25, 2024

Description (e.g. "Related to ...", etc.)

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@n-dusan
fix: raise UpdaterError if LVC is not valid
c5f6bc0 
Previously we were looking at output messages to figure out if git subprocess contained an error message.
@n-dusan n-dusan self-assigned this Sep 25, 2024
@n-dusan n-dusan marked this pull request as ready for review September 25, 2024 00:12
@n-dusan n-dusan added the bug Something isn't working label Sep 25, 2024
@renatav
Copy link
Collaborator

renatav commented Sep 28, 2024

Closing in favor of #543

@renatav renatav closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav Awaiting requested review from renatav

Assignees

@n-dusan n-dusan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-dusan @renatav