Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add notice level logging #538

Merged
merged 7 commits into from
Sep 28, 2024
Merged

feat: add notice level logging #538

merged 7 commits into from
Sep 28, 2024

Conversation

n-dusan
Copy link
Contributor

@n-dusan n-dusan commented Sep 24, 2024 •
edited
Loading

Description (e.g. "Related to ...", etc.)

  • Move default verbosity to 0 ("NOTICE") level
  • Add notice level logging for updating the repository and all dependent repositories

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

@n-dusan
feat(wip): add notice level logging
14e2664 
TODO: - remove extra new lines between each partner update; need to think carefully through wording about which repository got changed and how.
@n-dusan
chore: fix mypy typing
0fb661b
@n-dusan
fix: downgrade warning to debug
82bebb6 
This log is not particularly useful during update
@n-dusan n-dusan force-pushed the ndusan/notice-level-update-status branch from 587cc01 to 82bebb6 Compare September 27, 2024 19:35
@n-dusan n-dusan self-assigned this Sep 27, 2024
@n-dusan n-dusan marked this pull request as ready for review September 27, 2024 22:21
@n-dusan n-dusan force-pushed the ndusan/notice-level-update-status branch from 6cd9419 to da35421 Compare September 27, 2024 22:34
@renatav renatav merged commit 3b6fefc into master Sep 28, 2024
6 checks passed
@renatav renatav deleted the ndusan/notice-level-update-status branch September 28, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatav renatav renatav approved these changes

Assignees

@n-dusan n-dusan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-dusan @renatav