Ndusan/lifecycle handlers executable fixes #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we introduced LazyGroup, lots of modules are getting dynamically loaded. Add --collect-submodules to pyinstaller to resolve.
n-dusan
force-pushed
the
ndusan/lifecycle-handlers-executable-fixes
branch
from
65dd2bd
to
787b2dd
Compare
Used to execute arbitrary python scripts using a pre-built taf executable with pyinstaller. Lots of fixes were needed to get pyinstaller to correctly run a python script from subprocess. See [1] for pyinstaller discussion and the reasoning behind this. [1] - https://github.com/orgs/pyinstaller/discussions/5978
n-dusan
force-pushed
the
ndusan/lifecycle-handlers-executable-fixes
branch
from
8a4c9ec
to
ae4150b
Compare
renatav
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Fixes to lifecycle handlers needed to run python scripts from pre-built pyinstaller taf executable.
Code review checklist (for code reviewer to complete)