Apis docstirngs and improved logging, fix create repository #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-dusan
requested changes
Jul 4, 2023
Comment on lines
-423
to
+579
| repository = repository._tuf_repository | ||
| """ | ||
| Return role TUF object based on its name | ||
| """ | ||
| if isinstance(repository, Repository): | ||
| repository = repository._repository |
There was a problem hiding this comment.
Will repository be None if repository is not an instance of Repository?
There was a problem hiding this comment.
TBH, this was a quick fix because repository was either a TAF repository or a TUF repository (which is what repository._repository returns. We should look into all calls and standardize the input (either expect one or the other). Not sure if that's worth cramming into this PR because it's mostly focused on logging and docstirng. We could create an issue to make sure we don't forget about it
n-dusan
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Code review checklist (for code reviewer to complete)