refact: remove unused imports and variables

taf/api/metadata.py

@@ -1,5 +1,5 @@
 import datetime
-from logging import DEBUG, ERROR, INFO
+from logging import ERROR, INFO
 from pathlib import Path
 from logdecorator import log_on_end, log_on_error
 from taf.exceptions import TargetsMetadataUpdateError
@@ -111,7 +111,7 @@ def update_metadata_expiration_date(
             _update_expiration_date_of_role(
                 taf_repo, role, loaded_yubikeys, keystore, start_date, interval, scheme
             )
-        except Exception as e:
+        except Exception:
             return
 
     if no_commit:

taf/api/repository.py

@@ -1,7 +1,7 @@
 from functools import partial
-from logging import DEBUG, INFO
+from logging import DEBUG
 import click
-from logdecorator import log_on_end
+from logdecorator import log_on_end, log_on_start
 
 from collections import defaultdict
 from pathlib import Path
@@ -17,7 +17,7 @@
 from taf.log import taf_logger
 
 
-@log_on_end(DEBUG, "Creating a new authentication repository", logger=taf_logger)
+@log_on_start(DEBUG, "Creating a new authentication repository", logger=taf_logger)
 @log_on_end(DEBUG, "Created of a new repository finished", logger=taf_logger)
 def create_repository(
     repo_path, keystore=None, roles_key_infos=None, commit=False, test=False

taf/api/roles.py

@@ -1,4 +1,4 @@
-from logging import DEBUG, INFO
+from logging import DEBUG
 import os
 import click
 from collections import defaultdict
@@ -280,7 +280,6 @@ def add_signing_key(
     roles_key_infos, keystore = _initialize_roles_and_keystore(
         roles_key_infos, keystore, enter_info=False
     )
-    roles_infos = roles_key_infos.get("roles")
 
     pub_key_pem = None
     if pub_key_path is not None:

taf/api/yubikey.py

@@ -1,7 +1,6 @@
 import click
 
 from pathlib import Path
-from taf.constants import DEFAULT_RSA_SIGNATURE_SCHEME
 import taf.yubikey as yk