fix: partial update fixes #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue where only the newer dates were inserted when a new publication is pulled down. This meant that the new publication only had a single (newer) publication version entry, instead of the expected N (already inserted) entries. To fix, we now only set `last_inserted_date` for the current (already inserted) publication. For all publications following the current one, reset the `last_inserted_date`.
We no longer plan on using Postgres database connection. Keep the code flexible for now, though, where we can extend with new DB backends.
n-dusan
force-pushed
the
ndusan/partial-update-fixes
branch
from
dc596b3
to
c722e83
Compare
dgreisen
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Closes #53
publication_versionentries for new (incoming) publications.PostgresfromDatabaseKindenum.Code review checklist (for code reviewer to complete)
Automated tests, benchmarks and linters
You can run the tests, lints and benchmarks that are run on CI locally with: