Migrate JsonRPCServer.start_tcp
and JsonRPCServer.start_ws
to high level asyncio APIs
#507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the migration of the server-side of pygls to the higher level asyncio APIs
Closes #334
start_tcp
asyncio.start_server
gives us a reader, writer pair it's enough to reuse therun_async
method from thepygls.io_
module.start_ws
WebSocketTransportAdapter
intopygls.io_
and a newrun_websocket
function, allowing the websocket main loop to be shared between client and server codewebsockets.asyncio
APIIt's also worth noting that the test suite now includes the values of
--lsp-runtime
and--lsp-transport
in the header pytest prints at the start of a test runCode review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: