fix: return None
for non file:
URIs
#500
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #209 this tweaks the
to_fs_path
function to returnNone
when passed a URI that does not have afile:
scheme.This does have a few knock-on effects, but if anything it's going to highlight places where
pygls
makes some incorrect assumptionsCloses #209
Code review checklist (for code reviewer to complete)
Automated linters
You can run the lints that are run on CI locally with: