Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add systemd-language-server to implementations #436

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

psacawa
Copy link
Contributor

@psacawa psacawa commented Feb 22, 2024

Description (e.g. "Related to ...", etc.)

Add systemd-language-server to LSP implementations using pygls

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@tombh
Copy link
Collaborator

tombh commented Feb 22, 2024

Thank you! What a great LSP server 🤓

I can see that your commit message will need to follow the Conventional Commits syntax, so something like, docs: add systemd-language-server to implementations.

@psacawa
Copy link
Contributor Author

psacawa commented Mar 4, 2024

I have implemented this change

@tombh tombh merged commit f5de769 into openlawlibrary:main Mar 5, 2024
16 checks passed
@tombh tombh mentioned this pull request Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants