Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent AttributeError root_path when no workspace #396

Merged
merged 1 commit into from
Oct 6, 2023
Merged

fix: prevent AttributeError root_path when no workspace #396

merged 1 commit into from
Oct 6, 2023

Conversation

perrinjerome
Copy link
Contributor

fixes #395

Description (e.g. "Related to ...", etc.)

Please replace this description with a concise description of this Pull Request.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@tombh tombh self-requested a review October 6, 2023 15:29
@tombh tombh merged commit 6c5e295 into openlawlibrary:main Oct 6, 2023
17 checks passed
@perrinjerome perrinjerome deleted the fix/workspace_None branch October 6, 2023 15:30
@tombh
Copy link
Collaborator

tombh commented Oct 6, 2023

Thank you for the quick fix.

(That CI lint fail is CI's fault not yours)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tombh tombh tombh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Workspace._root_path attribute not set if if self._root_uri is None
2 participants
@perrinjerome @tombh