Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix use of deprecated methods in tests/test_language_server.py #384

Merged

Conversation

RossBencina
Copy link
Contributor

Description (e.g. "Related to ...", etc.)

Fixes the following two DeprecationWarnings:

tests/test_language_server.py::test_bf_text_document_did_open
  C:\_\pygls\tests\test_language_server.py:85: DeprecationWarning: 'workspace.documents' has been deprecated, use 'workspace.text_documents' instead
    assert len(server.lsp.workspace.documents) == 1

tests/test_language_server.py::test_bf_text_document_did_open
  C:\_\pygls\tests\test_language_server.py:87: DeprecationWarning: 'workspace.get_document' has been deprecated, use 'workspace.get_text_document' instead
    document = server.workspace.get_document(__file__)

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@tombh tombh force-pushed the fix_deprecation_warnings_in_tests branch from 69821d3 to 9018441 Compare October 2, 2023 12:51
@tombh tombh force-pushed the fix_deprecation_warnings_in_tests branch from 9018441 to 06d312e Compare October 2, 2023 12:56
@tombh tombh self-requested a review October 2, 2023 13:07
@tombh tombh merged commit f0762a7 into openlawlibrary:main Oct 2, 2023
17 checks passed
@tombh
Copy link
Collaborator

tombh commented Oct 2, 2023

Thank you again 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants