Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): bust cache #373

Merged
merged 1 commit into from
Sep 9, 2023
Merged

chore(ci): bust cache #373

merged 1 commit into from
Sep 9, 2023

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented Sep 7, 2023

Having problems in CI, looks like a bug got cached, hopefully just busting the cache fixes it.

@tombh tombh requested a review from alcarney September 7, 2023 17:36
@tombh
Copy link
Collaborator Author

tombh commented Sep 7, 2023

Actually, wait, I have another idea. Why not make -bustme be a Actions ENV var, so we can bust the cache just by changing the var in settings! I'll push that when I get a moment soon...

@alcarney
Copy link
Collaborator

alcarney commented Sep 7, 2023

Also, if you know which cache is bad you should be able to delete it from here - https://github.com/openlawlibrary/pygls/actions/caches

@alcarney
Copy link
Collaborator

alcarney commented Sep 8, 2023

I think the cache must be capturing the exact version of Python - (the Windows error message seems more useful)

No Python at '"C:\hostedtoolcache\windows\Python\3.11.4\x64\python.exe'

Which makes sense when you see that earlier in the run Python 3.11.5 was installed

Successfully set up CPython (3.11.5)

Is there a way for us to get the minor Python version number into the cache key? I wonder if actions/setup-python exports that as a step output 🤔

@tombh tombh force-pushed the tombh/cache-bust branch 2 times, most recently from 1c3f0a5 to 82fbc56 Compare September 8, 2023 22:07
@tombh
Copy link
Collaborator Author

tombh commented Sep 8, 2023

I didn't know about that cache page! That's really good to know.

And fantastic you found the underlying cause, I added the minor version to the cache key like you suggested.

@tombh tombh merged commit 22831fa into main Sep 9, 2023
@tombh tombh deleted the tombh/cache-bust branch September 9, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants