Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds type hierarchy request support #370

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

karthiknadig
Copy link
Contributor

@karthiknadig karthiknadig commented Sep 1, 2023

Description (e.g. "Related to ...", etc.)

Adds type hierarchy request support

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

This is still marked as "draft", so there's still some things to add?

Not that you need to change the tests, but I think the tests here could take advantage of the new LanguageClient that @alcarney has added. See here for an example. Like I say, you don't need to change the tests, it's just so you're aware.

@karthiknadig karthiknadig marked this pull request as ready for review September 1, 2023 21:34
@karthiknadig
Copy link
Contributor Author

@tombh I had kept is as draft because I was making sure my tests pass.

@tombh tombh mentioned this pull request Sep 1, 2023
7 tasks
@tombh tombh self-requested a review September 1, 2023 21:44
@tombh tombh merged commit 36aadbb into openlawlibrary:main Sep 1, 2023
@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

🚀

@karthiknadig karthiknadig deleted the type_hierarchies branch September 1, 2023 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants