Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions to README for using text files with vscode-playground #366

Conversation

RossBencina
Copy link
Contributor

No description provided.

@tombh
Copy link
Collaborator

tombh commented Sep 1, 2023

Thank you. This just needs the commit message to be updated, see the CI report here. Basically something like:
docs: using text files with vscode-playground

Edit: also needs a rebase of main to get the latest changes

@tombh tombh requested a review from alcarney September 1, 2023 18:05
@RossBencina RossBencina force-pushed the vscode-playground-readme-set-plaintext branch from 2273cab to ff49138 Compare September 25, 2023 06:45
@RossBencina
Copy link
Contributor Author

@tombh done.

@dhruvmanila
Copy link

Not sure if this can be added in this PR itself but for inlay_hints.py server, we need the notebook document selector as well:

"pygls.client.documentSelector": [
    {
        "notebook": "*",
        "language": "python"
    }
]

@RossBencina
Copy link
Contributor Author

This is just a fix for the README let's leave it at that.

@alcarney alcarney merged commit ec342a3 into openlawlibrary:main Sep 26, 2023
@alcarney
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants