Fix detection of LanguageServer
type annotation when future annotations are used
#352
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following example fails on
main
because the annotation is a string rather than a concrete type due to the use offrom __future__ import annotations
.typing.get_type_hints
can be used to resolve the annotations for the signature to support detection in this case.This can also be reproduced by wrapping the annotation type in a string manually (as I do in the test in this pull request).
Code review checklist (for code reviewer to complete)
[ ] Docstrings have been included and/or updated, as appropriate[ ] Standalone docs have been updated accordingly