Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin lsprotocol depdency #345

Closed
wants to merge 1 commit into from
Closed

fix: Pin lsprotocol depdency #345

wants to merge 1 commit into from

Conversation

tombh
Copy link
Collaborator

@tombh tombh commented Jun 20, 2023

This is on recommendation from the main lsprotocol developer. There is a much larger discussion around pinning in general, see: #331

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • CONTRIBUTORS.md was updated, as appropriate
  • Changelog has been updated, as needed (see CHANGELOG.md)

For more discussion see:
#331
@tombh tombh mentioned this pull request Jun 23, 2023
8 tasks
@tombh
Copy link
Collaborator Author

tombh commented Jun 23, 2023

We've actually got lsprotocol==2023.0.0a2 in master now, so I'll close this branch.

But one little open question I have is, is it worth testing out lsprotocol==2023.0.0a2 in the wild a little bit before making a new release of Pygls? #331 shows that there was a lot to take into consideration in introducing pinning, so maybe we should just make sure there aren't any unintended consequences first?

@karthiknadig
Copy link
Contributor

I think it is safe to pin 2023.0.0a2. I will be releasing 2023.0.0a3 next week and it will need some time in the wild to settle. My plan is to get this to stable this quarter. Then we can have pre-releases without impact to main pygls

@tombh
Copy link
Collaborator Author

tombh commented Jul 8, 2023

Thanks for the heads up. We'll make a release of that 2023.0.0a2 pin then, so you'll have the freedom to let 2023.0.0a3 into the wild without putting Pygls users into a tight spot.

@tombh tombh closed this Jul 8, 2023
@tombh tombh mentioned this pull request Jul 8, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants