Ensure that pygls.Server
uses the event loop it is given
#336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (e.g. "Related to ...", etc.)
Before this commit
pygls
would override the event loop for the current thread even when given an existing loop to use.Now
pygls
will rely onasyncio.new_event_loop
to create the appropriate event loop for the platform and only call it whenloop=None
This commit also introduces the
_own_loop
flag which is used to make surepygls
does not close an event loop it does not own.Related: #334
Code review checklist (for code reviewer to complete)