-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define approving process for changes to the Code of Conduct #889
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
+1 Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're expanding the scope of what's covered by the "governance of the CPC", we should make it really clear what is in fact covered. I would like this PR to include an explicit list of links to documents that is considered within the scope of that phrase. This should also make later changes easier to apply.
On the general idea of including the CoC to be a part of the "governance of the CPC", I definitely agree.
[Secondary CPC Director]: ../CPC-CHARTER.md#the-secondary-cpc-director-as-defined-in-43e-in-theopenjs-foundation-bylaws | ||
[Tertiary CPC Director]: ../CPC-CHARTER.md#the-tertiary-cpc-director-as-defined-in-43f-in-the-openjs-foundation-bylaws | ||
[Code of Conduct]: ../conduct | ||
[governance of the CPC]: ./ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implication of this link is that everything included in governance/
is covered. This is a bit confusing, as it does not included the code of conduct, but does include:
- Expectations of the Community Board of Directors representatives
- OpenJS GitHub Organization Management Policy
- OpenJS Foundation IP Policy Guidance
- Transferring an existing repository into the organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christian-bromann Have you had a chance to look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christian-bromann Ping?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 great looks good to me
The remaining issue seems to be defining an appropriate link for
used in this context
as pointed out by @eemeli. Since the affected file is |
Just a friendly bump to see if the requested changes can be addressed? |
Obsoleted by #1135 (the CPC is responsible for CoC changes using the processes described in |
In the last CPC working group session we have been working on some CoC issues and realised that we don't have a clear definition on the approval process for them. To have more clarity here we suggest to align the condition for merging changes to the CoC with changes to the governance of the CPC.
cc @jorydotcom @joesepi @SaraJo