Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define approving process for changes to the Code of Conduct #889

Closed
wants to merge 1 commit into from

Conversation

christian-bromann
Copy link
Member

In the last CPC working group session we have been working on some CoC issues and realised that we don't have a clear definition on the approval process for them. To have more clarity here we suggest to align the condition for merging changes to the CoC with changes to the governance of the CPC.

cc @jorydotcom @joesepi @SaraJo

@christian-bromann christian-bromann requested a review from a team May 18, 2022 12:31
Copy link
Member

@joesepi joesepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@rginn
Copy link

rginn commented May 18, 2022

+1 Thanks!

@jorydotcom jorydotcom self-requested a review May 18, 2022 16:23
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're expanding the scope of what's covered by the "governance of the CPC", we should make it really clear what is in fact covered. I would like this PR to include an explicit list of links to documents that is considered within the scope of that phrase. This should also make later changes easier to apply.

On the general idea of including the CoC to be a part of the "governance of the CPC", I definitely agree.

[Secondary CPC Director]: ../CPC-CHARTER.md#the-secondary-cpc-director-as-defined-in-43e-in-theopenjs-foundation-bylaws
[Tertiary CPC Director]: ../CPC-CHARTER.md#the-tertiary-cpc-director-as-defined-in-43f-in-the-openjs-foundation-bylaws
[Code of Conduct]: ../conduct
[governance of the CPC]: ./
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implication of this link is that everything included in governance/ is covered. This is a bit confusing, as it does not included the code of conduct, but does include:

  • Expectations of the Community Board of Directors representatives
  • OpenJS GitHub Organization Management Policy
  • OpenJS Foundation IP Policy Guidance
  • Transferring an existing repository into the organization

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christian-bromann Have you had a chance to look at this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@designMoreWeb designMoreWeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 great looks good to me

@mikesamuel
Copy link
Contributor

The remaining issue seems to be defining an appropriate link for

[governance of the CPC]: ./

used in this context

Pull requests that do not change the charter or governance of the CPC can be merged into
this repository provided the following conditions have been met:

as pointed out by @eemeli.

Since the affected file is governance/GOVERNANCE.md it seems like the context is apparent without a link.
Could we do away with the link and get the rest committed?

@ovflowd
Copy link
Member

ovflowd commented Dec 12, 2022

Just a friendly bump to see if the requested changes can be addressed?

@joesepi joesepi mentioned this pull request Jan 5, 2023
@tobie tobie added the TOPIC-code-of-conduct All issues related to the CoC update and process label Jun 28, 2023
@tobie tobie mentioned this pull request Jul 20, 2023
15 tasks
@tobie
Copy link
Contributor

tobie commented Feb 24, 2024

Obsoleted by #1135 (the CPC is responsible for CoC changes using the processes described in GOVERNANCE.md).

@tobie tobie closed this Feb 24, 2024
@ljharb ljharb deleted the cb-coc-update-process-refinements branch February 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOPIC-code-of-conduct All issues related to the CoC update and process
Projects
None yet
Development

Successfully merging this pull request may close these issues.