Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Caustics: A Python Package for Accelerated Strong Gravitational Lensing Simulations #6922

Closed
editorialbot opened this issue Jun 23, 2024 · 22 comments
Assignees
Labels
Dockerfile pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jun 23, 2024

Submitting author: @ConnorStoneAstro (Connor Stone)
Repository: https://github.com/Ciela-Institute/caustics
Branch with paper.md (empty if default branch): JOSS
Version: v0.10.1
Editor: @ivastar
Reviewers: @andigu
Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/995fa98462eb534a32952549ef2244f8"><img src="https://joss.theoj.org/papers/995fa98462eb534a32952549ef2244f8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/995fa98462eb534a32952549ef2244f8/status.svg)](https://joss.theoj.org/papers/995fa98462eb534a32952549ef2244f8)

Author instructions

Thanks for submitting your paper to JOSS @ConnorStoneAstro. Currently, there isn't a JOSS editor assigned to your paper.

@ConnorStoneAstro if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot editorialbot added pre-review Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences labels Jun 23, 2024
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.03283 is OK
- 10.21105/joss.02825 is OK
- 10.3847/1538-4357/ac6de4 is OK
- 10.48550/arXiv.2404.14487 is OK
- 10.1093/mnras/stu1859 is OK
- 10.1051/0004-6361/202039363 is OK
- 10.1051/0004-6361/201015481 is OK
- 10.48550/arXiv.2302.05329 is OK
- 10.1103/PhysRevD.106.122001 is OK
- 10.3847/1538-4357/acf5cd is OK
- 10.1117/1.JATIS.9.2.028007 is OK
- 10.1093/mnras/stad2477 is OK
- 10.1093/mnras/staa1477 is OK
- 10.1093/mnras/stac311 is OK
- 10.3847/1538-4357/ab4c41 is OK
- 10.48550/arXiv.2206.14820 is OK
- 10.48550/arXiv.2010.07032 is OK
- 10.48550/arXiv.2211.04365 is OK
- 10.48550/arXiv.2402.08725 is OK
- 10.1093/mnras/staa278 is OK
- 10.48550/arXiv.1805.07439 is OK
- 10.1093/mnras/stx2052 is OK
- 10.3847/1538-4357/abd62b is OK
- 10.1093/mnras/stz3094 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.48550/arXiv.1701.02434 is OK
- 10.1086/670067 is OK
- 10.1088/1475-7516/2016/11/048 is OK
- 10.1038/nature23463 is OK
- 10.3847/2041-8213/aa9704 is OK
- 10.1093/mnras/stu1284 is OK
- 10.1086/506266 is OK
- 10.48550/arXiv.2211.03812 is OK
- 10.3847/1538-4357/accf84 is OK
- 10.1051/0004-6361/202243054 is OK
- 10.1088/0004-637X/811/1/20 is OK
- 10.1038/s41550-021-01450-9 is OK
- 10.3847/2041-8213/ac9d39 is OK

MISSING DOIs

- No DOI given, and none found for title: LENSTOOL: A Gravitational Lensing Software for Mod...
- No DOI given, and none found for title: GRAVLENS: Computational Methods for Gravitational ...
- No DOI given, and none found for title: PyTorch: An Imperative Style, High-Performance Dee...
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: Numba: A llvm-based python jit compiler
- No DOI given, and none found for title: Pyro: Deep universal probabilistic programming

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (1191.7 files/s, 195393.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          93           3455           5728           7730
Jupyter Notebook                11              0           2181           1379
TeX                              1             46              0            685
Markdown                         9            164              0            655
YAML                            11             69             55            452
reStructuredText                 8             85             27            119
Dockerfile                       2             20             24             75
JSON                             2              4              0             64
TOML                             1              9              1             61
make                             1              4              6              9
Bourne Shell                     2              4              3              5
-------------------------------------------------------------------------------
SUM:                           141           3860           8025          11234
-------------------------------------------------------------------------------

Commit count by author:

   216	Connor Stone
   126	Adam Coogan
    38	AlexandreAdam
    27	Alexandre Adam
    21	Connor Stone, PhD
    20	Don Setiawan
    19	Andreas Filipp
    12	pre-commit-ci[bot]
    10	dependabot[bot]
     8	Cordero Core
     6	mjyb16
     1	Gabriel Missael Barco
     1	Landung 'Don' Setiawan

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 3248

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@dfm
Copy link

dfm commented Jun 23, 2024

@ConnorStoneAstro — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@dfm dfm added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jun 23, 2024
@editorialbot
Copy link
Collaborator Author

Five most similar historical JOSS papers:

lenstronomy II: A gravitational lensing software ecosystem
Submitting author: @sibirrer
Handling editor: @danielskatz (Active)
Reviewers: @smsharma, @coljac
Similarity score: 0.7770

COOLEST: COde-independent Organized LEns STandard
Submitting author: @aymgal
Handling editor: @plaplant (Active)
Reviewers: @smsharma, @AlexandreAdam
Similarity score: 0.7484

deeplenstronomy: A dataset simulation package for strong gravitational lensing
Submitting author: @rmorgan10
Handling editor: @pdebuyl (Active)
Reviewers: @shreyasbapat, @jiwoncpark
Similarity score: 0.7479

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology
Submitting author: @Jammy2211
Handling editor: @christinahedges (Retired)
Reviewers: @alexandergagliano, @sloneil
Similarity score: 0.7118

PyCS3: A Python toolbox for time-delay measurements in lensed quasars
Submitting author: @martin-millon
Handling editor: @arfon (Active)
Reviewers: @danhey, @coljac
Similarity score: 0.7063

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

@ivastar
Copy link

ivastar commented Jul 30, 2024

@editorialbot commands

@editorialbot
Copy link
Collaborator Author

Hello @ivastar, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author, a reviewer or the editor to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Set a value for the archive DOI
@editorialbot set 10.5281/zenodo.6861996 as archive

# Mention the EiCs for the correct track
@editorialbot ping track-eic

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Creates a post-review checklist with editor and authors tasks
@editorialbot create post-review checklist

# Open the review issue
@editorialbot start review

@ivastar
Copy link

ivastar commented Jul 30, 2024

@editorialbot assign @ivastar as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @ivastar is now the editor

@ivastar ivastar removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 30, 2024
@ivastar
Copy link

ivastar commented Jul 30, 2024

@ConnorStoneAstro I am taking over as editor. I will be looking for reviewers in the next week or so. Please let me know if you have suggestions for appropriate reviewers, here or via e-mail.

@ConnorStoneAstro
Copy link

Hi @ivastar that's great! There are many people who could give excellent reviews including: Simon Birrer, Andi Gu, Robert Morgan, James Nightingale, R. Benton Metcalf, Margarita Petkova, and Sebastian Wagner-Carena. They have all been involved in gravitational lensing software projects, and are cited in the paper.

@ivastar
Copy link

ivastar commented Aug 5, 2024

@rmorgan10, @swagnercarena would you be interested in reviewing this submission for JOSS?

The submission repository is at: https://github.com/Ciela-Institute/caustics You can see the full submission here: #6922 (this issue)

JOSS is a free, open-source, community driven and developer-friendly online journal.

The review process at JOSS place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements. See Review Criteria

Editors and reviewers post comments on the Review issue, and authors respond to the comments and improve their submission until acceptance (or withdrawal, if they feel unable to satisfy the review). We aim for reviews to be completed within about 3 weeks (~ end of August for this submission).

@ivastar
Copy link

ivastar commented Aug 5, 2024

@editorialbot add @andigu as reviewer

@editorialbot
Copy link
Collaborator Author

@andigu added to the reviewers list!

@ivastar
Copy link

ivastar commented Aug 7, 2024

@editorialbot ass @Jammy2211 as reviewer

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@ivastar
Copy link

ivastar commented Aug 7, 2024

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #7081.

@swagnercarena
Copy link

I am happy to review the submission if you are still looking for reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dockerfile pre-review Python TeX Track: 1 (AASS) Astronomy, Astrophysics, and Space Sciences
Projects
None yet
Development

No branches or pull requests

5 participants