Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: sumo: Command-line tools for plotting and analysis of ab initio calculations #682

Closed
whedon opened this issue Apr 18, 2018 · 25 comments

Comments

@whedon
Copy link

whedon commented Apr 18, 2018

Submitting author: @utf (Alex Ganose)
Repository: https://github.com/SMTG-UCL/sumo
Version: v1.0.4
Editor: @kyleniemeyer
Reviewers: @jarvist, @cfgoldsmith

Author instructions

Thanks for submitting your paper to JOSS @utf. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@utf if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Apr 18, 2018

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

@whedon
Copy link
Author

whedon commented Apr 18, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 18, 2018

PDF failed to compile for issue #682 with the following error:

/app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/author.rb:36:in block in build_affiliation_string': Problem with affiliations for Alex M Ganose, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/author.rb:35:in each'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/author.rb:35:in build_affiliation_string' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/author.rb:11:in initialize'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:89:in new' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:89:in block in parse_authors'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:87:in each' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:87:in parse_authors'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon.rb:68:in initialize' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/processor.rb:29:in new'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/lib/whedon/processor.rb:29:in set_paper' from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/bin/whedon:37:in prepare'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.3.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.3.0/bundler/gems/whedon-a31a5c2a9125/bin/whedon:99:in <top (required)>' from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in load'
from /app/vendor/bundle/ruby/2.3.0/bin/whedon:22:in `

'

@utf
Copy link

utf commented Apr 18, 2018

@whedon commands

@whedon
Copy link
Author

whedon commented Apr 18, 2018

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf

@utf
Copy link

utf commented Apr 18, 2018

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Apr 18, 2018

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Apr 18, 2018

@utf
Copy link

utf commented Apr 18, 2018

As for potential reviewers, the following people are well respected in the field and are familiar with the requirements of modern open-source projects:

@jarvist
@aronwalsh
@bjmorgan
@keeeto
@rgraucrespo
@hautierg

@arfon
Copy link
Member

arfon commented Apr 23, 2018

@kyleniemeyer - would you be willing to edit this submission for JOSS?

@utf
Copy link

utf commented May 1, 2018

Hi @arfon,

As @kyleniemeyer doesn't seem to be available, I wonder if @katyhuff might also be appropriate as an editor?

@kyleniemeyer
Copy link

@arfon sure, I can take this one

@kyleniemeyer
Copy link

@whedon assign @kyleniemeyer as editor

@whedon
Copy link
Author

whedon commented May 1, 2018

OK, the editor is @kyleniemeyer

@kyleniemeyer
Copy link

@cfgoldsmith has agreed to review; I am looking for one more based on the list of potentials mentioned above.

@utf
Copy link

utf commented May 2, 2018

Of the people I mentioned above, both @jarvist and @bjmorgan are already signed up as reviewers on JOSS.

@jarvist
Copy link

jarvist commented May 2, 2018

I'm happy to help! Though in the interest of full disclosure I know the two primary authors.

@kyleniemeyer
Copy link

@jarvist great! I was actually about to email you, so thanks for volunteering. Knowing the authors is fine, as long as you don't have a formal conflict of interest based on our policy: https://github.com/openjournals/joss/blob/master/COI.md

@kyleniemeyer
Copy link

@whedon add @jarvist as reviewer

@whedon whedon assigned kyleniemeyer and unassigned kyleniemeyer May 2, 2018
@whedon
Copy link
Author

whedon commented May 2, 2018

OK, @jarvist is now a reviewer

@kyleniemeyer
Copy link

@whedon add @cfgoldsmith as reviewer

@whedon
Copy link
Author

whedon commented May 2, 2018

OK, @cfgoldsmith is now a reviewer

@kyleniemeyer
Copy link

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented May 2, 2018

OK, I've started the review over in #717. Feel free to close this issue now!

@kyleniemeyer
Copy link

ok @utf @jarvist @cfgoldsmith we will hold the actual review over in #717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants