-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: fMRIStroke: A preprocessing pipeline for fMRI Data from Stroke patients #6636
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
Hello again! 👋 @behinger, @mnarayan, @SRSteinkamp FYI @alixlam This is the review thread for the paper. All of our higher-level communications will happen here from now on, review comments and discussion can happen in the repository of the project (details below). 📓 Please read the "Reviewer instructions & questions" in the comment from our editorialbot (above). ✅ All reviewers get their own checklist with the JOSS requirements - you generate them as per the details in the editorialbot comment. As you go over the submission, please check any items that you feel have been satisfied. 💻 The JOSS review is different from most other journals: The reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention the link to #6636 so that a link is created to this thread. That will also help me to keep track! ❓ Please also feel free to comment and ask questions on this thread if you are unsure about something! 🎯 We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @SRSteinkampConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
As seen above, create an issue regarding the mismatched between the listed installation requirements and python verison: alixlam/fmristroke#11 |
Review checklist for @behingerConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi all! @behinger, @SRSteinkamp -- I can see you have already made a lot of progress in your review! Thank you :-) What is your expected timeline for completing your part? Are there some issues that will take longer (e.g., because of iterations with @alixlam)? What's the general status? @mnarayan I haven't heard from you in some weeks, do you still intend to volunteer as a reviewer for this project? If so, what's your expected timeline for starting this review? |
Hi! Thanks for asking. I think we are both waiting for alixlam to post some test-data / procedure. alixlam/fmristroke#14 (comment) to get us up to speed. |
Hey @alixlam 👋 could you please supply a short update on your efforts on adding some test-data / procedure? |
Hello, so sorry for the time taken to respond. I did find open data to share and ran fMRIprep on it to have the necessary derivatives to test the repository. However, I am not sure it is a good idea to add the data files directly to the repository as they are quite heavy files. Do you have any suggestions on how to share them ? @sappelhoff @behinger |
You could upload them to osf (or fig share if you prefer), and link it. Then write a short documentation page how to access+run these data. Typically open euro is cc-by, so you can easily rehost. I would not necessarily run a system unit-test with them if they cannot be made smaller. |
Hey @alixlam 👋 do you have a status update for us? How is the uploading of the data and the writing of documentation on how to access and use it going? |
Some data can be found here : https://osf.io/5z4ry/. With raw data and fmriprep derivatives. The documentation has been updated especially the Usage Notes part. |
Hey @alixlam I can see some recent activity in alixlam/fmristroke#17 (comment) Could you please report on your expected timeline to address other issues raised by the reviewers, such as: |
Submitting author: @alixlam (Alix Marie Eleonore Lamouroux)
Repository: https://github.com/alixlam/fmristroke
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @sappelhoff
Reviewers: @SRSteinkamp, @behinger, @mnarayan
Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@SRSteinkamp & @behinger & @mnarayan, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sappelhoff know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @SRSteinkamp
📝 Checklist for @behinger
The text was updated successfully, but these errors were encountered: