-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: FIGARO: hierarchical non-parametric inference for population studies #6589
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
License info: ✅ License found: |
|
@dgerosa, @Uddiptaatwork — This is the review thread for the paper. All of our correspondence will happen here from now on. Thanks again for agreeing to participate! 👉 Please read the "Reviewer instructions & questions" in the first comment above, and generate your checklists by commenting The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please try to make a start ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. Please get your review started as soon as possible! |
Review checklist for @dgerosaConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @sterinaldi, nice work. Here are my comments following the checklist above:
|
I also have a comment/question for @dfm, which is about the scope of JOSS. The authors already published a paper in the scientific literature that presents their FIGARO code: Monthly Notices of the Royal Astronomical Society: Letters, Volume 517, Issue 1, November 2022, Pages L5–L10, https://doi.org/10.1093/mnrasl/slac101 This JOSS paper also presents the code and their other paper provides more details. Should there be a JOSS paper for this code? Should this submission be considered a duplicate? |
@dgerosa — Thanks for checking in! I normally try to check this before the review starts, but sometimes things slip through. When submitting, @sterinaldi commented "This code and documentation has not been submitted, nor we are planning to submit it, to another peer-reviewed journal.", but I agree that there does seem to be significant overlap with that MNRAS paper. Our policy on co-publication is described here. The idea is that it is ok to publish a JOSS paper when the methods or applications have been published elsewhere, but it's not ok to co-publish primarily about the software in multiple venues. @sterinaldi — Perhaps you could provide your perspective on the relationship between this submission and the previous publication. Thanks! |
Hi @dfm – It is indeed true that we already presented a part of FIGARO in Rinaldi & Del Pozzo (2022) [RDP, hereafter] as mentioned by @dgerosa. From my perspective, however, it satisfies JOSS policy on co-publication for the following reasons:
I hope this answers your questions, but I'm happy to comment more on this if you feel that it's needed! |
Review checklist for @UddiptaatworkConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@sterinaldi — Thanks for your response above and I'm so sorry about my delayed reply. This does sound to me like this submission is sufficiently different from the MNRAS publication to be consistent with the JOSS requirements. With this in mind, I think we should continue with the review. Thanks again to @dgerosa for checking in on this point! |
Hi @dgerosa, sorry for my late reply. Thanks for your review, below you find my reply and changes:
I hope this addresses your comments! |
Thanks @sterinaldi. Green light from me. |
Thanks @dgerosa! @Uddiptaatwork — A reminder to keep this on your radar. Please revisit your review ASAP! |
Dear @sterinaldi @dfm apologies for the delay, we experienced a disruptive few weeks at the institute due to ongoing geopolitical issues. |
Hi @Uddiptaatwork, thanks! Concerning the warnings, I'm not really sure about what's going on there, to be honest. I was aware of these warnings (MacOS, M1), but they are relative to a documentation line (the first two, the fact that I wrote Edit: I just checked, it's an issue with backslashes. I simply converted individual backslashes to double backslashes (https://stackoverflow.com/questions/52335970/how-to-fix-syntaxwarning-invalid-escape-sequence-in-python). |
Perfect, thanks for looking into this! |
@editorialbot generate pdf |
|
@dgerosa, @Uddiptaatwork — Thanks for your thorough and constructive reviews!! @sterinaldi — I've opened a small PR with some minor edits to the manuscript, please take a look and merge or let me know what you think. Once you've done that:
|
Hi @dfm – I merged your PR. The updated version number of the code is v1.6.7 and the DOI is 10.5281/zenodo.11302325 |
@editorialbot set v1.6.7 as version |
Done! version is now v1.6.7 |
@editorialbot set 10.5281/zenodo.11302325 as archive |
Done! archive is now 10.5281/zenodo.11302325 |
@editorialbot check references |
@editorialbot generate pdf |
|
@editorialbot recommend-accept |
|
|
👋 @openjournals/aass-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5388, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@dgerosa, @Uddiptaatwork — Many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!! @sterinaldi — Your paper is now accepted and published in JOSS! ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @sterinaldi (Stefano Rinaldi)
Repository: https://github.com/sterinaldi/FIGARO
Branch with paper.md (empty if default branch): joss-paper
Version: v1.6.7
Editor: @dfm
Reviewers: @dgerosa, @Uddiptaatwork
Archive: 10.5281/zenodo.11302325
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dgerosa & @Uddiptaatwork, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @dgerosa
📝 Checklist for @Uddiptaatwork
The text was updated successfully, but these errors were encountered: