-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Reggae: A Parametric Tuner for PBJam, and a Visualization Tool for Red Giant Oscillation Spectra #6329
Comments
Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Checking the BibTeX entries failed with the following error:
|
|
Failed to discover a valid open source license |
Failed to discover a |
|
@darthoctopus — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience! In the meantime, I believe that the errors raised here are happening because the paper must be called |
Oops, I'd meant to rename the markdown file before submission but somehow overlooked that. I have now done so. @editorialbot generate pdf As far as I can see, of the reviewers on the big list, only Dan Hey has indicated expertise with asteroseismology. As such, I think we will indicate a preference for him to review. |
@editorialbot generate pdf |
|
hmm, very confused by this bc it builds just fine on my local machine. Third time's the charm? |
@editorialbot generate pdf |
Five most similar historical JOSS papers: pySYD: Automated measurements of global asteroseismic parameters
Virgo: A Versatile Spectrometer for Radio Astronomy Model dispersion with PRISM; an alternative to MCMC for rapid analysis of models Reel1.0 - A visualization tool for evaluating powder diffraction refinements |
@editorialbot check references |
|
Hi @darthoctopus, sorry about the long wait. I'll pick this up now and start looking for reviewers. If there's anyone you'd like to suggest that don't constitute a conflict of interest, do let me know! |
@editorialbot assign me as editor |
Assigned! @warrickball is now the editor |
I just want to flag for @dfm that I'm technically a conflict of interest myself. @darthoctopus and I have both been authors on some consortium papers organised by the TESS Asteroseismic Science Consortium (TASC) but we've also both contributed to PBjam, on which Reggae depends. My contributions to PBjam have been very limited, though. Regarding the code, Reggae doesn't clearly come across clearly as a tool intended for other researchers using PBjam. You may want to have a look at the JOSS review criteria in anticipation. For example, I couldn't easily find installation instructions or a worked example. The GUI screenshot in the |
@warrickball thanks for the heads up. Logistically, will we be permitted to push changes to the main branch for consideration during the review, or will we have to wait for each report before doing so? |
You can certainly iterate during review and I think most authors do respond to the review by making changes to the repository. The JOSS review process is intended to be very iterative and reviewers may comment on one aspect of the code at a time, so that you're working on one part (e.g. documentation) while they review another (e.g. testing). |
@editorialbot add @sybreton as reviewer |
@sybreton added to the reviewers list! |
@editorialbot add @sblunt as reviewer |
@sblunt added to the reviewers list! |
On closer inspection, my conflict of interest with the co-authors on this submission are too much to waive, so I'm going to hand this over to @dfm to edit. |
@editorialbot assign @dfm as editor |
Assigned! @dfm is now the editor |
@editorialbot start review Thanks @warrickball for getting this rolling! The main review will happen in a new thread and I'll meet you over there shortly. |
OK, I've started the review over in #6588. |
Submitting author: @darthoctopus (Joel Ong J. M.)
Repository: https://github.com/darthoctopus/reggae
Branch with paper.md (empty if default branch): joss
Version: git
Editor: @dfm
Reviewers: @sybreton, @sblunt
Managing EiC: Dan Foreman-Mackey
Status
Status badge code:
Author instructions
Thanks for submitting your paper to JOSS @darthoctopus. Currently, there isn't a JOSS editor assigned to your paper.
@darthoctopus if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.
Editor instructions
The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:
The text was updated successfully, but these errors were encountered: