-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Model dispersion with PRISM; an alternative to MCMC for rapid analysis of models #1229
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @fonnesbeck it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
As mentioned in the blog here (http://blog.joss.theoj.org/2018/12/a-new-collaboration-with-aas-publishing), @fonnesbeck @arokem Do you need the AAS Journals submission reference for this by any chance? |
@1313e many thanks for letting us know about this - I think you're the first! @fonnesbeck - when you get a chance, please review this blog post from late last year: http://blog.joss.theoj.org/2018/12/a-new-collaboration-with-aas-publishing . In particular, please let us know if you have any objection to JOSS receiving a small donation from AAS publishing for this. |
Yeah, the news about that collaboration came just in time before my paper submission, so I am not surprised I am the first one. |
@arfon May I btw mention that AAS Journals has no system in place at all that a submission is being accompanied by a JOSS submission? |
Yes, I think this is still a work in progress. / cc @crawfordsm who is the software editor for AAS so he has some visibility into this review too. |
Apologies, unfortunately, I did not see a note about this on the AAS side. I'll have to follow up about that, but thanks for letting me know! As this is the first paper, it will be great to use as an example of the process. |
@crawfordsm Do you, by any chance, need the submission reference, to make it easier to find which paper it actually is that I submitted to AAS Journals? |
It's okay, I have the information. I am the Scientific Editor for the paper, so I can monitor it here as well as on the AAS side. I realize now that I had just overlooked the information. As of right now, we do not have a formal process for this, but appreciate your patience as we figure out the details. |
Hi @arfon: thanks for the heads up about this. Do I understand correctly that the process here is essentially the same as for other JOSS papers? That is, review and acceptance here are not tied in any way to the AAS paper. Is that correct? |
That's mostly correct. We may want to hold this paper back from final acceptance until we know what the DOI for the AAS paper will be (so we can cite it). |
Understood! OK - @fonnesbeck - if this all sounds agreeable to you, please do go ahead with your review. Once the review process here is over, we can circle back and see what we need to do. Thanks! |
@arfon That would be required anyways, given that I am citing the AAS Journals submission for the results. I hope that is okay btw, as I couldn't find any guidelines on this. |
👍 yes that's right. We also don't allow scientific results to be published in JOSS :-)
I think you've got this right. @crawfordsm and I are in the process of drafting some guidelines that should assist future authors. |
@1313e the test suite fails on both Linux and macOS for me.
|
I'm having problems running the example model. See 1313e/PRISM#7 |
@fonnesbeck You will have to install all requirements in |
Yes, at the moment the install instructions do not mention |
@fonnesbeck Alright, I have added it to the README. |
Tests now run after installing the dev requirements, but the tests fail. |
The submission satisfies all of the evaluation criteria. Once the issue above is addressed, I'm happy to recommend ACCEPT. |
@fonnesbeck I have solved the problem with 1313e/PRISM#8, and also improved the README and docs on the topic of running the pytests. @arokem Do you have an idea how I can fix the formatting error that whedon gives when compiling the |
@1313e - I’ll have to fix the name issue manually at the end (the automated proofs will continue to have this problem) |
I am now able to run the test suite without issue. There are no other outstanding problems, so I recommend ACCEPT. cc @arfon |
@whedon generate pdf |
|
@1313e - I'm going to go ahead and accept this paper now as I believe the AAS paper is very close to being published too. Apologies for the back and forth on this submission - you're the first author to follow the dual-publishing workflow in AAS/JOSS and we've been finding (and fixing) a few challenges along the way. Your patience has been much appreciated! |
@fonnesbeck - many thanks for your review here and to @arokem for editing this submission ✨ @1313e - your paper is now accepted into JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@arfon Will you also make sure that my last name is properly written in the published version? |
Certainly. Can you verify that it looks correct in the pdf here? http://joss.theoj.org/papers/f31acc7b1be30757526442034888aabf |
Looks fine to me. |
@arfon I was actually just looking at the paper, and noticed that the citations are not displayed properly. The first in every sequence is, but the other ones are not. |
@1313e - could you be more specific about what you're seeing that you believe is incorrect? i.e. give me an example of expected vs actual? |
@arfon Well, the second sentence of the third paragraph shows up as "PRISM uses the Bayes linear approach (Goldstein & Wooff, 2007), emulation technique (Craig, Goldstein, Seheult, & Smith, 1996, p. @craig97) and history matching (Raftery, Givens, & Zeh, 1995, pp. @Craig96, @craig97)...". |
Ah, right. Sorry about that. The correct syntax for multiple citations is to separate them with semi-colons (e.g. |
@arfon Thanks for that, but I think you will have to manually set my last name in the footer again... |
The paper is now fixed. Can you check that this looks OK? https://www.doi2bib.org/bib/10.21105/joss.01229 |
That link does not resolve. |
Weird works fine for me. Can you try going to https://www.doi2bib.org/ and putting in If that doesn't work, the output from the service (i.e. the bibtex entry from the Crossref metadata) is:
☝️does that look OK? |
Uhm, my last name should be in braces, as otherwise it will not be formatted correctly. It does seem though that for my paper, my name is at least written correctly. |
OK, thanks. I don't have any control over where https://www.doi2bib.org puts the braces but the metadata looks correct.
OK, that's fixed for |
Alright, thanks. |
@arfon This is not that big of a deal, but I just realized that the footer in the JOSS paper says 'van der Velden et al.', even though I am the sole author on the paper. |
Sorry about that. This should be fixed now. Note, the new pdf can take a few hours to show up sometimes because of browser caching. |
Submitting author: @1313e (Ellert van der Velden)
Repository: https://github.com/1313e/PRISM
Version: v1.0.0
Editor: @arokem
Reviewer: @fonnesbeck
Archive: 10.5281/zenodo.2572736
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@fonnesbeck, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @fonnesbeck
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: