[PRE REVIEW]: A C++ template library for polynomials algebra over discrete euclidean domains

[editorialbot]

Submitting author: @JeWaVe (regis portalez)
Repository: https://github.com/aerobus-open-source/aerobus
Branch with paper.md (empty if default branch):
Version: v1.1
Editor: @gkthiruvathukal
Reviewers: @mmoelle1, @lucaferranti, @pitsianis
Managing EiC: Daniel S. Katz

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a2759ec3461f6e6c635fca88c9bddcad"><img src="https://joss.theoj.org/papers/a2759ec3461f6e6c635fca88c9bddcad/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a2759ec3461f6e6c635fca88c9bddcad/status.svg)](https://joss.theoj.org/papers/a2759ec3461f6e6c635fca88c9bddcad)

Author instructions

Thanks for submitting your paper to JOSS @JeWaVe. Currently, there isn't a JOSS editor assigned to your paper.

@JeWaVe if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (306.9 files/s, 109753.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                     1            358             91           1494
C++                              2            129             42            976
Markdown                         2            110              0            565
JSON                             3              0              0             85
YAML                             1              4              4             31
TeX                              1              3              0             27
make                             1              4              0             11
-------------------------------------------------------------------------------
SUM:                            11            608            137           3189
-------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

[editorialbot]

Wordcount for paper.md is 2200

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-06486-4_7 is OK

MISSING DOIs

- None

INVALID DOIs

- None

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[editorialbot]

Five most similar historical JOSS papers:

Universal Numbers Library: Multi-format Variable Precision Arithmetic Library
Submitting author: @Ravenwater
Handling editor: @danielskatz (Active)
Reviewers: @mmoelle1, @mlxd, @yboettcher
Similarity score: 0.8229

Castor: A C++ library to code "à la Matlab"
Submitting author: @matthieuaussal
Handling editor: @jbytecode (Active)
Reviewers: @mkitti, @pitsianis
Similarity score: 0.8150

cppduals: a nestable vectorized templated dual number library for C++11
Submitting author: @tesch1
Handling editor: @danielskatz (Active)
Reviewers: @StewMH, @mdavezac
Similarity score: 0.8120

ChebTools: C++11 (and Python) tools for working with Chebyshev expansions
Submitting author: @ianhbell
Handling editor: @labarba (Retired)
Reviewers: @drvinceknight
Similarity score: 0.8074

Cadabra2: computer algebra for field theory revisited
Submitting author: @kpeeters
Handling editor: @danielskatz (Active)
Reviewers: @StewMH, @henrik227
Similarity score: 0.8073

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

[danielskatz]

@gkthiruvathukal - would you be willing to edit this submission?

[danielskatz]

@editorialbot invite @gkthiruvathukal as editor

[editorialbot]

Invitation to edit this submission sent!

[gkthiruvathukal]

@danielskatz Yes. Will assign self as editor!

[gkthiruvathukal]

@editorialbot assign me as editor

[editorialbot]

Assigned! @gkthiruvathukal is now the editor

[JeWaVe]

@editorialbot generate pdf

I pushed some modifications in both paper and bibligraphy.

[editorialbot]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[gkthiruvathukal]

@drvinceknight Are you willing to help review this JOSS submission?

[gkthiruvathukal]

@mmoelle1 Are you willing to help review this JOSS submission?

[gkthiruvathukal]

Once I have two reviewers, review will begin.

[gkthiruvathukal]

@JeWaVe As we await the reviewers, I notice that this C++ project is a bit lacking when it comes to the build process. The Makefile doesn't appear to be portable. You should consider using a Makefile generator (e.g. autoconf) or a more modern build system. I personally use CMake in my projects.

[JeWaVe]

Ok. Im currently AFK but I'll find some time to fix that later this week. Thank you Envoyé depuis Proton Mail mobile

…

-------- Message d'origine -------- Le 23 oct. 2023 à 04:36, George K. Thiruvathukal a écrit :

***@***.***(https://github.com/JeWaVe) As we await the reviewers, I notice that this C++ project is a bit lacking when it comes to the build process. The Makefile doesn't appear to be portable. You should consider using a Makefile generator (e.g. autoconf) or a more modern build system. I personally use CMake in my projects. — Reply to this email directly, [view it on GitHub](#5942 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ACXJDMLY6LN2VBBN6OVVZMLYAXJ4JAVCNFSM6AAAAAA56WSPQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZUGM2DEMZRGI). You are receiving this because you were mentioned.Message ID: ***@***.***>

[mmoelle1]

Yes, @gkthiruvathukal I am willing to review this JOSS submission

[JeWaVe]

Hi @gkthiruvathukal I just added a cmakelists.txt and updated the readme.
In addition, I added some documentation (not complete at all) and updated the readme (main branch)

[JeWaVe]

Hi. It's been a month with no news. Where are we in the reviewing process ? (I do not publish that often so I don't know if it's normal or not).

[gkthiruvathukal]

@JeWaVe I am sorry for the delay. Things have been uncharacteristically busy in my life but I will try to make some forward progress here.

[gkthiruvathukal]

@editorialbot add @mmoelle1 as reviewer

[editorialbot]

@mmoelle1 added to the reviewers list!

[gkthiruvathukal]

@henrik227 Are you willing to help review this JOSS submission?

[gkthiruvathukal]

@pitsianis Are you willing to help review this JOSS submission?

[gkthiruvathukal]

@mkitti Are you willing to review this JOSS submission?

[JeWaVe]

Hi everyone,

I just added a major update with implementation of galois fields (GF(p, n) for all p < 1000 and n < 20).
Everything is in the main branch, I hope I didn't break anything here.

[mkitti]

@gkthiruvathukal I'm still finishing another review and otherwise busy. I might be able to join later if needed once that concludes. I have discussed this with @lucaferranti, and he is interested and is capable as a reviewer.

[lucaferranti]

@gkthiruvathukal , yes I can review this

[pitsianis]

My apologies for replying late, I will be happy to assist if needed.

[gkthiruvathukal]

@editorialbot add @lucaferranti as reviewer

[editorialbot]

@lucaferranti added to the reviewers list!

[gkthiruvathukal]

@editorialbot add @pitsianis as reviewer

[editorialbot]

@pitsianis added to the reviewers list!

[gkthiruvathukal]

@lucaferranti and @pitsianis Thank you for being willing to review this submission. Now I can start the review...

[gkthiruvathukal]

@editorialbot start review

[editorialbot]

OK, I've started the review over in #6233.