-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: CiteLang: Modeling the Research Software Ecosystem #4458
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
👋🏼 @vsoch @gflofst @rmmilewi this is the review thread for the paper. All of our communications will happen here from now on. As a reviewer, the first step is to create a checklist for your review by entering
as the top of a new comment in this thread. These checklists contain the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. The first comment in this thread also contains links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if any of you require some more time. We can also use EditorialBot (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@faroit) if you have any questions/concerns. |
Hey @faroit ! 👋 Just wanted to check in and see if you need anything from me? Happy Saturday! 🥤 |
To be clear, I am in fact going to review this paper. I was without reliable internet for a few days while moving houses. But I'm back online and should have this review done in the next day or two! |
Congrats on your move! 🏡 |
@editorialbot remind @rmmilewi in seven days |
Reminder set for @rmmilewi in seven days |
@editorialbot remind @gflofst in seven days |
Reminder set for @gflofst in seven days |
I was on travel for a week and then the US holiday on Monday. This week I'll get started. |
Review checklist for @gflofstConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@vsoch I do not see any automated testing support. That is the only thing that might be missing as far as I can see. |
We do have automated tests! They are run via GitHub workflows:
And here is an example of the "main" test run - if you look under "Run Tests" you'll see lots of output that shows what is going on. https://github.com/vsoch/citelang/runs/6640961948?check_suite_focus=true You can also see the tests here: https://github.com/vsoch/citelang/tree/main/citelang/tests As an addition, citlelang runs weekly to update the rsepedia, and although it's not an official test, I check that the results look as I'd expect. That's probably a sanity check for a more complex usecase that combines many of the subcommands! Let me know if you have any questions! |
That is excellent. If you could copy and lightly edit that into the installation instructions, it'll be 100% complete. |
Will do - probably first thing after the work day. Ty! |
okay all set! Added a new test section: https://vsoch.github.io/citelang/getting_started/installation.html#testing |
This looks great! All requirements are passed for me. |
Thank you @rmmilewi ! ❤️ |
@editorialbot generate pdf |
@editorialbot check references |
|
@vsoch Everything looks good from my side. For the next steps, please make a new release of the package and archive it, for example on zenodo. Once you complete those tasks, please report here the version number and doi. Please ensure that the archive's author names and title match exactly those of the paper.pdf. |
okay DOI is created, added to the repository along with a CITATION.cff! https://github.com/vsoch/citelang I think Zenodo might be lagged in actually creating the page for it - there is a notification at the top about uploading issues. So I can't edit the metadata and ensure the author/title are OK, but I'll keep checking it today and update when I can. I can also ping you here when it is fully formed if you like! Thankfully we have the metadata
|
Update: is working! And I've fixed the title and my author name! https://zenodo.org/record/7048920 |
@editorialbot set https://doi.org/10.5281/zenodo.7048920 as archive |
Done! Archive is now https://doi.org/10.5281/zenodo.7048920 |
@editorialbot set 0.0.33 as version |
Done! version is now 0.0.33 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3493, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@gflofst, @rmmilewi – many thanks for your reviews here and to @faroit for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @vsoch – your paper is now accepted and published in JOSS ⚡🚀💥 This is such a neat piece of work – I'm hoping I get to use it! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@vsoch congrats and thanks for all your patience! I am not very happy with duration of the review process so I want to apologize for the delay also were coming from my side. I hope you will choose JOSS again and I will try harder to speed up the process next time. |
it's okay @faroit - thank you so kindly for moving it along! I have a pretty cool project under development called tunel that I'll eventually submit, so I'll definitely be back for a next time! I'm trying to limit myself to one paper / year to not overwhelm the process - I'm just really appreciative for JoSS! I tend to not be a fan of publication as a means to derive our worth but I think y'all are doing it right - a focus on reviewing the code, testing, and documentation. Happy Monday! |
Submitting author: @vsoch (Vanessa Sochat)
Repository: https://github.com/vsoch/citelang
Branch with paper.md (empty if default branch):
Version: 0.0.33
Editor: @faroit
Reviewers: @gflofst, @rmmilewi
Archive: https://doi.org/10.5281/zenodo.7048920
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@gflofst & @rmmilewi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @faroit know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @gflofst
📝 Checklist for @rmmilewi
The text was updated successfully, but these errors were encountered: