-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Comrade: Composable Modeling of Radio Emission #4457
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@mileslucas, @cescalara – This is the review thread for the paper. All of our communications will happen here from now on. Please read the "Reviewer instructions & questions" in the first comment above. Please create your checklist typing:
As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for the review process to be completed within about 4-6 weeks but please make a start well ahead of this as JOSS reviews are by their nature iterative and any early feedback you may be able to provide to the author will be very helpful in meeting this schedule. |
Review checklist for @mileslucasConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @cescalaraConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@arfon I'm satisfied with my review of Comrade, let me know if there's anything I need to do! |
Thanks for confirming @mileslucas! @cescalara - how are you getting along with your review? |
I plan to send my review this week or early next week! |
Excellent! Thanks for the update. |
Hi @arfon, I've also completed my review and can recommend Comrade.jl for publication! |
@editorialbot generate pdf |
Awesome news, thanks so much @cescalara! @ptiede – At this point could you make a new release of this software that includes the changes that have resulted from this review. Then, please make an archive of the software in Zenodo/figshare/other service and update this thread with the DOI of the archive? For the Zenodo/figshare archive, please make sure that:
I can then move forward with accepting the submission. |
First, @cescalara and @mileslucas thanks for all your hard work the package is much better now! The most recent version of Comrade has all the requested updates during the referee process. I have gone ahead and created a zenodo release for the most recent version the doi is: https://doi.org/10.5281/zenodo.6977819 Let me know if you need anything else! |
@editorialbot set 10.5281/zenodo.6977819 as archive |
Done! Archive is now 10.5281/zenodo.6977819 |
@ptiede - it looks like |
@editorialbot generate pdf |
@editorialbot generate pdf |
@editorialbot generate pdf |
@arfon should be fixed now! sorry about that |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3430, then you can now move forward with accepting the submission by compiling again with the command |
@ptiede – found a couple of typos in the paper: ptiede/Comrade.jl#170 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3431, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@mileslucas, @cescalara – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @ptiede – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @ptiede (Paul Tiede)
Repository: https://github.com/ptiede/Comrade.jl
Branch with paper.md (empty if default branch): joss-paper
Version: v0.3.1
Editor: @arfon
Reviewers: @mileslucas, @cescalara
Archive: 10.5281/zenodo.6977819
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@mileslucas & @cescalara, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @mileslucas
📝 Checklist for @cescalara
The text was updated successfully, but these errors were encountered: