-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: Synthia: multi-dimensional synthetic data generation in Python #2779
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
PDF failed to compile for issue #2779 with the following error: Can't find any papers to compile :-( |
@whedon generate pdf from branch joss-paper |
|
@whedon query scope |
Submission flagged for editorial review. |
Hi @dmey, thanks for your submission to JOSS. Due to the relatively small size of your software package, the editorial board is going to take a closer look at whether it falls within our scope. |
Hi @kyleniemeyer, many thanks for letting me know. In case this may be of relevance to the board, this package have been used in two papers (currently in preparation) which I am planning to submit in the next few weeks. Furthermore, the tool is novel in its approach, well written and likely to be cited by future machine learning (ML) groups. |
@kyleniemeyer just as clarification to my previous message -- as I am going to upload the scientific papers that make use of/cite Synthia on arXiv in a couple of weeks while their peer-review takes place, I can update this thread with links to those respective papers. Originally, I thought that this was going to be discussed during review but I am more than happy to wait here if that will make it easier to show the novelty and contribution of this tool to the community. |
I'm having a look at the paper regarding the scope query requested by @kyleniemeyer . Is it normal that the paper is extremely short? The Github pdf only contains a "Summary" and "Acknowledgments" sections, it seems rather incomplete and I wonder if this is an involuntary mistake |
@VivianePons thanks for looking into this. My understanding is that the summary paper needs to be very short -- abstract like -- as it is meant only as summary of the motivation and purpose of the tool and because the purpose of the review is to review the software rather than paper as done in more traditional journals. I have checked again at https://joss.readthedocs.io/en/latest/submitting.html and it says that the summary paper should be between 250-1000 words but I am more than happy to extend this, especially given that my first draft was much much longer and cut it down considerably at submission to make it more to the point. |
Indeed, papers are rather short but they are still a bit more furnished. Look at our example paper: https://joss.readthedocs.io/en/latest/submitting.html#example-paper-and-bibliography In particular, papers should contain a "Statement of need" which is missing in your case. You can also have some other sections such as "Features", "Examples" You can browse through our recent publications to give you an idea. |
@VivianePons many thanks for clarifying this, please allow me to make the necessary changes as advised. |
@whedon check references from branch joss-paper |
|
|
In particular, I would like to understand what your software adds specifically in terms of implementation. Considering the small amount of code, we might fear that it is mainly a python wrapper to some other tools like vinecopulib. Could you give us some information regarding this aspect? |
@dmey - could you elaborate? This will help us making our editorial scope decision. |
@arfon -- may I give you my response by early next week? |
No problem! |
@VivianePons apologies for the delay but I have had no time to look at this yet -- could I get back sometime in the next week? Thanks. |
@whedon generate pdf from branch joss-paper |
|
@arfon @VivianePons @kyleniemeyer and @danielskatz many thanks for allowing me to get back to you this week. We have recently extended the documentation, added more examples, and reworded the paper to address what I think were your main concerns. We have also added a couple of new features, that is, the handling of discrete and categorical data in the last two releases which brings the number of lines of pure Python code to 1097 (please see With regards to your individual questions --
@VivianePons thanks for raising this -- looking at the paper and repository with fresh eyes, I can see how this was unclear. I have now made changes to the repository, paper and website and hope that the changes make the purpose clearer. With regards to your specific question, Synthia can currently be used to model univariate and multivariate data, parameterize marginals with empirical and parametric methods and apply manipulations such as stretching and uniformization (I have added a summary at https://dmey.github.io/synthia/features.html). For multivariate data we support three different types of methods: fPCA, parametric (Gaussian) copula, and vine copula models and provide a pure Python implementation for the former two and rely on vinecopulib for the latter. Recently we have also added the capability to handle discrete and categorical data when using vine copulas.
We have tried to write Synthia succinctly and the current lines of pure Python code according to the The scope of the journal (https://joss.readthedocs.io/en/latest/submitting.html) indicates that [our bold]:
I cited a paper which is going to be submitted in the next few 10 days, I will let you know as soon as it's been deposited to that I can update the reference. And apologies for the long text but I thought it would be best to address everything in one long comment. As a side note, I think there is a small issue with typesetting the figures in the paper (Table 1). Would it be possible to reduce the text size or change the width by a little so that the code blocks display as one liners. Otherwise I could move them to a different layout. Output from the
|
@whedon check repository |
|
@openjournals/dev - any comments on this question from the author:
|
👋 @oliviaguest - would you be willing to edit this for JOSS? |
@whedon invite @oliviaguest as editor |
@oliviaguest has been invited to edit this submission. |
I am really inundated with work at the moment, so on the proviso I can start (looking for reviewers, etc.) next week, sure. |
Sure, that's fine! |
@whedon assign @oliviaguest as editor |
OK, the editor is @oliviaguest |
@dmey can you give me some ideas for reviewers, please? 😊 |
OK, @khinsen is now a reviewer |
@oliviaguest, sure -- from the list of potential reviewers I have identified the following people who may be suitable to review this submission:
In case none is available please let me know and I can suggest more. |
I would be happy to review. |
OK, @mnarayan is now a reviewer |
@whedon start review |
OK, I've started the review over in #2863. |
Submitting author: @dmey (D. Meyer)
Repository: https://github.com/dmey/synthia
Version: 1.0.0
Editor: @oliviaguest
Reviewers: @khinsen, @mnarayan
Managing EiC: Kyle Niemeyer
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Author instructions
Thanks for submitting your paper to JOSS @dmey. Currently, there isn't an JOSS editor assigned to your paper.
The author's suggestion for the handling editor is @arfon.
@dmey if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: