[PRE REVIEW]: ELDAM: A Python software for Life Cycle Inventory data management

[whedon]

Submitting author: @GustaveCoste (Gustave Coste)
Repository: https://framagit.org/GustaveCoste/eldam
Version: V1.0
Editor: @sjpfenninger
Reviewers: @konstantinstadler, @romainsacchi
Managing EiC: Kristen Thyng

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @GustaveCoste. Currently, there isn't an JOSS editor assigned to your paper.

The author's suggestion for the handling editor is @sjpfenninger.

@GustaveCoste if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

[whedon]

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

[whedon]

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=1.82 s (53.8 files/s, 7627.0 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          50           1980           1943           5067
Qt                              10              0              0           3047
SVG                             10              8              6            877
reStructuredText                24            252            199            457
DOS Batch                        2              8              1             30
make                             1              4              6             10
INI                              1              0              0              2
-------------------------------------------------------------------------------
SUM:                            98           2252           2155           9490
-------------------------------------------------------------------------------


Statistical information for the repository '9562c73e5278aa16bc004d02' was
gathered on 2020/10/09.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Gustave Coste                  496         28421          19431          100.00

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Gustave Coste              8990           31.6         20.0               11.43

[whedon]

PDF failed to compile for issue #2735 with the following error:

Can't find any papers to compile :-(

[kthyng]

@whedon generate pdf from branch joss

[whedon]

Attempting PDF compilation from custom branch joss. Reticulating splines etc...

[whedon]

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

[kthyng]

@sjpfenninger would you be willing to edit this? I see you have 4 currently, but one is about to be wrapped up so I thought it might be ok.

[kthyng]

@whedon invite @sjpfenninger as editor

[whedon]

@sjpfenninger has been invited to edit this submission.

[sjpfenninger]

@whedon assign @sjpfenninger as editor

[whedon]

OK, the editor is @sjpfenninger

[sjpfenninger]

@konstantinstadler 👋 Would you be willing to review this submission to JOSS?

[sjpfenninger]

@GustaveCoste Thanks for your submission! It looks like there are two broken references in the PDF (and a typo next to one of them: "inteface"). Can you fix those?

[konstantinstadler]

@konstantinstadler wave Would you be willing to review this submission to JOSS?

Hi, happy to do the review, but can only do that next week.

[GustaveCoste]

Hi, thank you for initiating the review process. I tried to fix the broken references without success. The strange thing is that I can't see the difference with the example.

Here is the figure:
![Review procedure.\label{fig:review}](review.png)

And the reference to it:
... helps to improve the LCIs quality (\autoref{fig:review}).

Should the figure be inserted before the reference?

[sara-02]

Hey folks, I am available to review more packages, and while this tool is not right up my alley(I work with Python but not software workflow tools), if you need more reviewers for this I am available to help 23rd Oct onwards :)

[sjpfenninger]

@konstantinstadler Looks like it's next week anyway now, so I'll take you up on the offer. Thanks!

[sjpfenninger]

Thanks @sara-02, let me see if we find somebody with expertise in the area.

[sjpfenninger]

@romainsacchi Would you be able to review this submission to JOSS?

[sjpfenninger]

@whedon add @konstantinstadler as reviewer

[whedon]

OK, @konstantinstadler is now a reviewer

[sjpfenninger]

@GustaveCoste Hmm, I'm unsure what's happening there. @openjournals/dev Any idea why following the figure referencing approach from the example does not work in this case?

[arfon]

@GustaveCoste Hmm, I'm unsure what's happening there. @openjournals/dev Any idea why following the figure referencing approach from the example does not work in this case?

No idea at all sorry. I've been debugging this for the last hour and can't get it to work (I'm currently trying to figure out if this has ever worked 😕). For now, I suggest simply cross-linking manually by just writing out the figure name in the text (e.g. Figure 1 shows...).

[arfon]

Actually, turns out this is a whitespace issue. If you give your figures some whitespace, e.g., change L65 onward to look like this:

`ELDAM` has been used in various research projects [@Gentil:2020], helping to improve and characterize LCI data quality. Its review procedure has proven very helpful for auditing the LCIs produced by LCA beginners such as interns.

![Review procedure.\label{fig:review}](review.png)

![ELDAM's GUI.\label{fig:gui}](gui.png)

you should find it works.

[romainsacchi]

Yes, I can do that.

…

On 20 Oct 2020, at 16:12, Stefan Pfenninger ***@***.***> wrote:  @romainsacchi Would you be able to review this submission to JOSS? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[romainsacchi]

@sjpfenninger yes, I can do that.

[GustaveCoste]

@arfon Thank you it fixed the problem.

[sjpfenninger]

@whedon add @romainsacchi as reviewer

[whedon]

OK, @romainsacchi is now a reviewer

[sjpfenninger]

Thanks @romainsacchi !

[sjpfenninger]

@whedon start review

[whedon]

OK, I've started the review over in #2765.

[sjpfenninger]

@konstantinstadler , @romainsacchi thanks for agreeing to review. Let's head over to #2765 for the actual review!