-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: PyQMRI: An accelerated Python based Quantitative MRI Python toolbox #2727
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @grlee77, @ @agahkarakuzu, @DARSakthi it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2727 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in |
@whedon generate pdf from branch joss-paper |
|
PDF failed to compile for issue #2727 with the following error: sh: 1: cd: can't cd to 09e65fba2022502e74700760 |
@whedon generate pdf from branch JOSS_pub |
|
PDF failed to compile for issue #2727 with the following error: pandoc-citeproc: reference agahkarakuzu not found Looks like we failed to compile the PDF |
@MaierOli2010 can you check ☝️ that reference? |
@Kevin-Mattheus-Moerman agahkarakuzu should be the git name of one of the reviewers. I do not have any reference that could conatin that name though (just checked the paper.bib file). |
@openjournals/dev @arfon have a look at this issue ☝️, it looks like when I assigned agahkarakuzu as reviewer over at #2718 they got a double |
@whedon generate pdf from branch JOSS_pub |
|
@Kevin-Mattheus-Moerman - I just edited the issue manually. |
@Kevin-Mattheus-Moerman I came back to this issue to see the latest changes, then noticed that I still don't appear on the list of reviewers. |
@agahkarakuzu I think this looks good now right? Can you confirm you are able to tick boxes? |
@grlee77, @agahkarakuzu, @DARSakthi thanks for your review efforts!!! If see some of you have left some boxes unticked. If you could summarize for the authors what work is needed that would be great. Thanks. |
@Kevin-Mattheus-Moerman I cannot check the boxes :/ |
@whedon re-invite @agahkarakuzu as reviewer |
@whedon generate pdf |
@whedon generate pdf from branch JOSS_pub |
1 similar comment
@MaierOli2010 I have two minor points about the paper:
|
@Kevin-Mattheus-Moerman |
@whedon generate pdf |
@whedon accept |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1978 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1978, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations @MaierOli2010! Thanks for another excellent review @grlee77, @agahkarakuzu, @DARSakthi!!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @MaierOli2010 (Oliver Maier)
Repository: https://github.com/IMTtugraz/PyQMRI
Version: v1.0.0
Editor: @Kevin-Mattheus-Moerman
Reviewer: @grlee77, @agahkarakuzu, @DARSakthi
Archive: 10.5281/zenodo.4313301
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@grlee77 & @agahkarakuzu & @DARSakthi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @grlee77
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @agahkarakuzu
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @DARSakthi
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: