Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Fireworks: Reproducible Machine Learning with PyTorch #1422

Closed
whedon opened this issue May 1, 2019 · 28 comments
Closed

[PRE REVIEW]: Fireworks: Reproducible Machine Learning with PyTorch #1422

whedon opened this issue May 1, 2019 · 28 comments

Comments

@whedon
Copy link

whedon commented May 1, 2019

Submitting author: @smk508 (Saad Khan)
Repository: https://github.com/kellylab/Fireworks
Version: 0.3.0
Editor: @arokem
Reviewers: dirmeier

Author instructions

Thanks for submitting your paper to JOSS @smk508. Currently, there isn't an JOSS editor assigned to your paper.

@smk508 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 1, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented May 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 1, 2019

PDF failed to compile for issue #1422 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/author.rb:58:in block in build_affiliation_string': Problem with affiliations for Saad Khan, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/author.rb:57:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/author.rb:57:in build_affiliation_string' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/author.rb:17:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon.rb:109:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon.rb:109:in block in parse_authors'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon.rb:106:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon.rb:106:in parse_authors'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon.rb:73:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:32:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/lib/whedon/processor.rb:32:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-a1723d160bb6/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@smk508
Copy link

smk508 commented May 1, 2019

@whedon commands

@whedon
Copy link
Author

whedon commented May 1, 2019

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

@smk508
Copy link

smk508 commented May 1, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented May 1, 2019

@kyleniemeyer
Copy link

@smk508 I am looking for a JOSS editor to handle the submission; once someone is assigned, they will work to assign reviewers.

@smk508
Copy link

smk508 commented May 2, 2019

Ok thanks!

@arokem
Copy link

arokem commented May 3, 2019

I can handle this one.

@arokem
Copy link

arokem commented May 3, 2019

@whedon assign arokem as editor

@whedon
Copy link
Author

whedon commented May 3, 2019

OK, the editor is arokem

@arokem
Copy link

arokem commented May 3, 2019

@smk508 : do you have any suggestions for reviewers? You can also look here

@smk508
Copy link

smk508 commented May 4, 2019

Hi @arokem . Thanks so much! I looked through the spreadsheet for people who are experts in machine learning, big data, and/or bioinformatics. There's a lot of people, so I'm not sure who makes the most sense, but I just picked out some names. I think if there's someone who has experience designing or contributing to machine learning / big data frameworks such a TensorFlow / PyTorch / Spark, that person would probably have good insight to give since this library is a framework meant to facilitate machine learning.

Here are some names as I skimmed the spreadsheet:

Simon Dirmier
Niranjan Padmanabhan (username: neurons)
Divya Sardanda

@arokem
Copy link

arokem commented May 6, 2019

👋 @dvysardana: would you be willing to review this paper for JOSS? It seems right up your alley!

@arokem
Copy link

arokem commented May 10, 2019

I'll give @dvysardana a few more days to reply here, but if I don't hear back I'll ping other potential reviewers next week.

@smk508
Copy link

smk508 commented May 11, 2019

Ok thanks

@smk508
Copy link

smk508 commented May 20, 2019

Hi @arokem , what's the status on the paper review?

@arokem
Copy link

arokem commented May 21, 2019

Sorry - I have been traveling and away from this pre-review.

@arokem
Copy link

arokem commented May 21, 2019

👋 @dirmeier : would you be willing to review this paper for JOSS?

@dirmeier
Copy link

dirmeier commented May 23, 2019

Hey, I'm so sorry for the late reply. I totally forgot answering. Yes, I'd be very happy to review!

@smk508
Copy link

smk508 commented May 24, 2019

Hi @dirmeier thanks for reviewing my submission! What are the next steps @arokem ?

@arokem
Copy link

arokem commented May 25, 2019

@whedon assign dirmeier as reviewer

@whedon
Copy link
Author

whedon commented May 25, 2019

OK, the reviewer is dirmeier

@arokem
Copy link

arokem commented May 25, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented May 25, 2019

OK, I've started the review over in #1478. Feel free to close this issue now!

@arokem
Copy link

arokem commented May 25, 2019

@dirmeier : thanks for taking this on! Please head over to #1478 for the review. I'll close this issue now.

@arokem arokem closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants