[PRE REVIEW]: gtk-fortran: a GTK+ binding to build Graphical User Interfaces in Fortran #1014

whedon · 2018-10-11T11:54:30Z

Submitting author: @vmagnin (Vincent MAGNIN)
Repository: https://github.com/jerryd/gtk-fortran
Version: v17.10
Editor: @Kevin-Mattheus-Moerman
Reviewers: @johnsamuelwrites, @devonrex, @sundmanbo

Author instructions

Thanks for submitting your paper to JOSS @vmagnin. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@vmagnin if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

The text was updated successfully, but these errors were encountered:

whedon · 2018-10-11T11:54:33Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @Kevin-Mattheus-Moerman it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

whedon · 2018-10-11T11:54:33Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-10-11T11:54:43Z

PDF failed to compile for issue #1014 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon/orcid_validator.rb:12:in initialize': undefined method strip' for nil:NilClass (NoMethodError)
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon.rb:91:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon.rb:91:in block in check_orcids'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon.rb:89:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon.rb:89:in check_orcids'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon.rb:70:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon/processor.rb:32:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/lib/whedon/processor.rb:32:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/bin/whedon:37:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-7ea7c17cf2a1/bin/whedon:99:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

arfon · 2018-10-11T11:54:58Z

👋 @Kevin-Mattheus-Moerman - the submitting author suggested you as the handling editor.

arfon · 2018-10-11T11:56:07Z

@vmagnin - this pull request should fix the paper compilation: vmagnin/gtk-fortran#124

vmagnin · 2018-10-11T16:43:20Z

@vmagnin - this pull request should fix the paper compilation: jerryd/gtk-fortran#124

@arfon - I have merged your pull request. Effectively, one of the author has no ORCID.

Kevin-Mattheus-Moerman · 2018-10-12T09:35:52Z

@whedon generate pdf

whedon · 2018-10-12T09:35:57Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-10-12T09:36:31Z

👉 Check article proof 📄 👈

Kevin-Mattheus-Moerman · 2018-10-12T09:40:11Z

@daviddoria is this submission of interest to you and would you be able to help review it?

Kevin-Mattheus-Moerman · 2018-10-12T10:04:08Z

@molines @bjonkman @szaghi @alexlarsson @komatits would you be interested in reviewing this work for the Journal of Open Source Software (JOSS)? The review process focuses on the software and a short paper.
Let me know if you have questions.

daviddoria · 2018-10-12T13:24:32Z

No to both, sorry :) David

…

On Fri, Oct 12, 2018 at 4:40 AM Kevin Mattheus Moerman < ***@***.***> wrote: @daviddoria <https://github.com/daviddoria> is this submission of interest to you and would you be able to help review it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1014 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AANID1AmBcXO-E3cGvwSq522sYQfYf9Fks5ukGOAgaJpZM4XXYU8> .

vmagnin · 2018-10-12T14:02:29Z

point_right Check article proof page_facing_up point_left

@Kevin-Mattheus-Moerman
In the proof, there is a problem with two citations: in the .bib matcalfe2011 should be replaced by metcalfe2011. Should I push the correction on the repository of the project ?
Concerning the softwares references, I guess "n.d." means "no date" ? And when the author is a community, how should the reference appear in the .bib ?
Thanks

vmagnin · 2018-10-12T14:03:43Z

@whedon commands

whedon · 2018-10-12T14:03:46Z

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Compile the paper
@whedon generate pdf

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper from a custom git branch
@whedon generate pdf from branch custom-branch-name

Kevin-Mattheus-Moerman · 2018-10-12T14:17:07Z

Yes do implement the changes in your own repo. You can call @whedon generate pdf yourself here whenever you want to re-render the pdf.

@arfon can you help answer the question about citing a software package when the author is a community, what should be changed in this:

@misc{plplot,
author = {The Plplot developer community},
title = {PLplot - The ultimate in cross-platform plotting},
howpublished = {\url{http://plplot.sourceforge.net/}}
}

to avoid it being rendered as:
community, T. P. developer. (n.d.). PLplot - the ultimate in cross-platform plotting. http://plplot.sourceforge.net/.

alexlarsson · 2018-10-12T14:43:15Z

Sorry, I don't have any time to review this.

vmagnin · 2018-10-15T09:05:39Z

@whedon generate pdf

Corrected metcalf2011 reference
Corrected author J. De Lisle affiliation
improved reference to Tincher2017 paper
added date to DISLIN reference

whedon · 2018-10-15T09:05:44Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-10-15T09:06:09Z

👉 Check article proof 📄 👈

vmagnin · 2018-10-15T12:34:41Z

@Kevin-Mattheus-Moerman
@arfon

Browsing a lot of JOSS papers, I found one citing the R software using:

@Manual{R2018,
	title = {R: A Language and Environment for Statistical Computing},
	author = {{R Core Team}},
	organization = {R Foundation for Statistical Computing},
	address = {Vienna, Austria},
	year = {2018},
	url = {https://www.R-project.org/},
}

The result is:
suppdata is an R (R Core Team 2018) package to provide easy,

In fact, two curly brackets like in author = {{R Core Team}} prevent the compiler to search for first name and last name in the string.

vmagnin · 2018-10-15T13:03:54Z

@whedon generate pdf

Tried to improve references

whedon · 2018-10-15T13:03:59Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-10-15T13:04:10Z

PDF failed to compile for issue #1014 with the following error:

% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed

0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 15 0 15 0 0 127 0 --:--:-- --:--:-- --:--:-- 128
Error reading bibliography ./paper.bib (line 66, column 1):
unexpected "@"
expecting space, ",", white space or "}"
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

vmagnin · 2018-10-15T13:06:40Z

@whedon generate pdf

Kevin-Mattheus-Moerman · 2018-11-02T10:38:59Z

@johnsamuelwrites (https://orcid.org/0000-0001-8721-7007) thanks for joining as a reviewer! This is a pre-review issue where we gather reviewers. The review process will be initiated later and takes place on a dedicated review issue. In the meantime you can familiarize yourself with the review guidelines. Let me know if you have questions.

johnsamuelwrites · 2018-11-02T10:46:12Z

Thank you @Kevin-Mattheus-Moerman for the invitation. I will finish the review in the upcoming days.

vmagnin · 2018-11-02T17:08:12Z

@vmagnin I'll still looking for reviewers. Let me know if you have any in mind.

Dear @Kevin-Mattheus-Moerman ,
I have found two persons who agree to be reviewers: @devonrex and @sundmanbo (OK in two weeks)

vmagnin · 2018-11-02T17:22:12Z

@vmagnin I am unable to access your website URL shown at the top of your project http://gtk+fortran, is it broken?

@Kevin-Mattheus-Moerman
The URL http://gtk+fortran is probably an error in the settings of the project, dating back to the origin of the project... There is no other site than https://github.com/jerryd/gtk-fortran (or its wiki page https://github.com/jerryd/gtk-fortran/wiki).
I will ask @jerryd, who originally created that repository, to delete that URL.

Update (7th February 2019): it is corrected.

Kevin-Mattheus-Moerman · 2018-11-05T10:35:00Z

@vmagnin your paper currently reads:

A Graphical User Interface (GUI) can be useful in a research software to visualize results in real time during a computation, to plot results or to interact with the user, especially if the software is used by other people or distributed outside the laboratory.

It would be good if you could expand on this a bit more. JOSS has, in some cases, rejected GUI library submissions in the past if they did not present with a clear research application. We often try to understand if the work is of such importance to some scientific research that authors would feel inclined to cite it in subsequent papers. If they would not feel so inclined the software is likely seen and used as a simple tool, and not important enough to the actual scientific research.

If you study our submission requirements you'll see it says:

The software should have an obvious research application

Can you please expand your paper to really spell out exactly how this work is relevant to scientific research? How would the work feature in scientific research? How does the work influence the science? Does the work enable new scientific research or make it easier? Give (and perhaps cite) some specific examples of how this work is relevant in particular research applications. Creating a section that answers the above questions will help sketch a picture for readers, allowing them to understand how this work might be important enough to some scientific research that researchers will feel the need to cite it in their paper.

Kevin-Mattheus-Moerman · 2018-11-20T08:35:38Z

@vmagnin can you reply to my comment above please. Thanks.

vmagnin · 2018-11-20T11:31:34Z

@vmagnin can you reply to my comment above please. Thanks.

Dear @Kevin-Mattheus-Moerman
sorry for the delay, of course I have read your request and I have begun thinking about the arguments to add in the paper. But I was busy with other things these last weeks.
I will work on it this week.

vmagnin · 2018-11-26T09:45:43Z

@Kevin-Mattheus-Moerman
I have modified the paper:

The introduction paragraph has been expanded, and splitted in two. A reference was added.
Added the following sentences in the (now) third paragraph :
- "The gtkf-sketcher tool even makes easier the design of a complex GTK+3 GUI by automatically generating the Fortran code from the XML files created by the user interface designer software Glade [glade]."
- "They can for example implement visual management of tree-like data structures for handling of complex data projects."

P.S. I hope the "@" mentions will work in this message, because today the github editor does not seem to recognize them...

vmagnin · 2018-11-26T10:44:00Z

@Kevin-Mattheus-Moerman
Please read my last message. Github seems now to work properly !

vmagnin · 2018-11-26T10:45:59Z

@whedon generate pdf

whedon · 2018-11-26T10:46:02Z

Attempting PDF compilation. Reticulating splines etc...

whedon · 2018-11-26T10:46:36Z

👉 Check article proof 📄 👈

sundmanbo · 2018-11-29T09:09:55Z

@Kevin-Mattheus-Moerman Hi, I have started the review and managed to install the software with minor problems.

Kevin-Mattheus-Moerman · 2018-11-29T09:27:39Z

@whedon add @devonrex as reviewer

whedon · 2018-11-29T09:27:44Z

OK, @devonrex is now a reviewer

Kevin-Mattheus-Moerman · 2018-11-29T09:27:58Z

@whedon add @sundmanbo as reviewer

whedon · 2018-11-29T09:28:04Z

OK, @sundmanbo is now a reviewer

Kevin-Mattheus-Moerman · 2018-11-29T09:29:28Z

@whedon start review

whedon · 2018-11-29T09:29:33Z

OK, I've started the review over in #1109. Feel free to close this issue now!

Kevin-Mattheus-Moerman · 2018-11-29T09:31:00Z

@vmagnin thanks for providing the additional clarifications in your paper. I will suggest further edits to the paper (saw some language/spelling issues) but have started the review process.

whedon assigned Kevin-Mattheus-Moerman Oct 11, 2018

whedon added the pre-review label Oct 11, 2018

whedon added CMake Fortran Python labels Oct 11, 2018

This was referenced Nov 2, 2018

Unable to run the demo example given in the documentation vmagnin/gtk-fortran#125

Closed

Missing information in Documentation vmagnin/gtk-fortran#126

Closed

whedon assigned johnsamuelwrites and Kevin-Mattheus-Moerman and unassigned Kevin-Mattheus-Moerman Nov 29, 2018

whedon assigned johnsamuelwrites and Kevin-Mattheus-Moerman and unassigned johnsamuelwrites and Kevin-Mattheus-Moerman Nov 29, 2018

Kevin-Mattheus-Moerman closed this as completed Nov 29, 2018

[PRE REVIEW]: gtk-fortran: a GTK+ binding to build Graphical User Interfaces in Fortran #1014

[PRE REVIEW]: gtk-fortran: a GTK+ binding to build Graphical User Interfaces in Fortran #1014

Comments

whedon commented Oct 11, 2018 • edited Loading

whedon commented Oct 11, 2018

whedon commented Oct 11, 2018

whedon commented Oct 11, 2018

arfon commented Oct 11, 2018

arfon commented Oct 11, 2018

vmagnin commented Oct 11, 2018 • edited Loading

Kevin-Mattheus-Moerman commented Oct 12, 2018

whedon commented Oct 12, 2018

whedon commented Oct 12, 2018

Kevin-Mattheus-Moerman commented Oct 12, 2018

Kevin-Mattheus-Moerman commented Oct 12, 2018

daviddoria commented Oct 12, 2018 via email

vmagnin commented Oct 12, 2018 • edited Loading

vmagnin commented Oct 12, 2018

whedon commented Oct 12, 2018

Kevin-Mattheus-Moerman commented Oct 12, 2018

alexlarsson commented Oct 12, 2018

vmagnin commented Oct 15, 2018

whedon commented Oct 15, 2018

whedon commented Oct 15, 2018

vmagnin commented Oct 15, 2018 • edited Loading

vmagnin commented Oct 15, 2018

whedon commented Oct 15, 2018

whedon commented Oct 15, 2018

vmagnin commented Oct 15, 2018

Kevin-Mattheus-Moerman commented Nov 2, 2018

johnsamuelwrites commented Nov 2, 2018

vmagnin commented Nov 2, 2018 • edited Loading

vmagnin commented Nov 2, 2018 • edited Loading

Kevin-Mattheus-Moerman commented Nov 5, 2018 • edited Loading

Kevin-Mattheus-Moerman commented Nov 20, 2018

vmagnin commented Nov 20, 2018

vmagnin commented Nov 26, 2018 • edited Loading

vmagnin commented Nov 26, 2018 • edited Loading

vmagnin commented Nov 26, 2018

whedon commented Nov 26, 2018

whedon commented Nov 26, 2018

sundmanbo commented Nov 29, 2018

Kevin-Mattheus-Moerman commented Nov 29, 2018

whedon commented Nov 29, 2018

Kevin-Mattheus-Moerman commented Nov 29, 2018

whedon commented Nov 29, 2018

Kevin-Mattheus-Moerman commented Nov 29, 2018

whedon commented Nov 29, 2018

Kevin-Mattheus-Moerman commented Nov 29, 2018

whedon commented Oct 11, 2018 •

edited

Loading

vmagnin commented Oct 11, 2018 •

edited

Loading

vmagnin commented Oct 12, 2018 •

edited

Loading

vmagnin commented Oct 15, 2018 •

edited

Loading

vmagnin commented Nov 2, 2018 •

edited

Loading

vmagnin commented Nov 2, 2018 •

edited

Loading

Kevin-Mattheus-Moerman commented Nov 5, 2018 •

edited

Loading

vmagnin commented Nov 26, 2018 •

edited

Loading

vmagnin commented Nov 26, 2018 •

edited

Loading