Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: A course on the implicit finite volume method for CFD using Python #66

Closed
whedon opened this issue Aug 1, 2019 · 40 comments

Comments

@whedon
Copy link

whedon commented Aug 1, 2019

Submitting author: @ctdegroot (Christopher DeGroot)
Repository: https://bitbucket.org/cdegroot/cfdcourse
Version: v1.0
Editor: @IanHawke
Reviewers: @sconde, @zingale

Author instructions

Thanks for submitting your paper to JOSE @ctdegroot. The JOSE editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@ctdegroot if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSE and may be suitable for this submission.

Editor instructions

The JOSE submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 1, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Aug 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 1, 2019

PDF failed to compile for issue #66 with the following error:

Can't find any papers to compile :-(

@whedon
Copy link
Author

whedon commented Aug 1, 2019

Failed to discover a valid open source license.

@labarba
Copy link
Member

labarba commented Aug 1, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 1, 2019

PDF failed to compile for issue #66 with the following error:

Can't find any papers to compile :-(

@labarba
Copy link
Member

labarba commented Aug 1, 2019

@arfon Why is whedon unable to find the paper file? It is there in the repo ... is it a Bitbucket thing?

@arfon
Copy link
Member

arfon commented Aug 1, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 1, 2019

PDF failed to compile for issue #66 with the following error:

Can't find any papers to compile :-(

@arfon
Copy link
Member

arfon commented Aug 1, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 1, 2019

PDF failed to compile for issue #66 with the following error:

Can't find any papers to compile :-(

@arfon
Copy link
Member

arfon commented Aug 1, 2019

Looks like the file is named Paper.md rather than paper.md. Whedon is case sensitive I'm afraid.

@labarba
Copy link
Member

labarba commented Aug 1, 2019

Thanks, Arfon!

👋 @ctdegroot — Could you please rename the file of your paper to paper.md?

@labarba
Copy link
Member

labarba commented Aug 1, 2019

You'll also need to rename the .bib file.

@ctdegroot
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 1, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 1, 2019

@ctdegroot
Copy link

@labarba Got that naming issue sorted. The PDF looks good.

For reviewers, I could suggest @kyleniemeyer, @sconde, or @TJFord to start. Also noticed that it flagged a lack of license file; I'll get that fixed up before the review begins.

@labarba
Copy link
Member

labarba commented Aug 5, 2019

👋 @IanHawke — could you handle this new JOSE submission as editor?

@labarba
Copy link
Member

labarba commented Aug 8, 2019

@whedon assign @IanHawke as editor

@whedon
Copy link
Author

whedon commented Aug 8, 2019

OK, the editor is @IanHawke

@labarba
Copy link
Member

labarba commented Aug 8, 2019

Thanks for agreeing to edit this for JOSE, @IanHawke !
Since this is your first one, a few notes:

  • We'll want to identify two reviewers… we have a list of people who have signed up to review, but you're free to look outside that.
  • For the first reviewer, use the command @whedon assign <user> as reviewer and for the second, run @whedon add <user> as reviewer (if you use assign the second time around, it will remove the original assignment).
  • Once both are assigned, run @whedon start review and close this issue. A Review issue will be automatically created, with a review checklist for each reviewer.

@IanHawke
Copy link

IanHawke commented Aug 9, 2019

Right, thanks for starting me off with what looks like a great course!

In addition to the license file, I'd suggest a requirements.txt or similar to get the environment set up: not essential.

@IanHawke
Copy link

IanHawke commented Aug 9, 2019

@zingale: Mike, are you able to and interested in taking on this review for JOSE (the Journal of Open Source Education) ? This submission is about implicit methods for CFD and uses Python and Jupyter: I think you would be an excellent reviewer. Please see the JOSE reviewer guidelines for details about the JOSE review process.

Title: A course on the implicit finite volume method for CFD using Python
Summary: .A course on Computational Fluid Dynamics using Jupyter Notebooks and Python
Article Proof: https://github.com/openjournals/jose-papers/blob/jose.00066/jose.00066/10.21105.jose.00066.pdf
Submitting author: @ctdegroot (Chris DeGroot)
Repository: https://bitbucket.org/cdegroot/cfdcourse

@IanHawke
Copy link

IanHawke commented Aug 9, 2019

@sconde: Sidafa Conde, are you able to and interested in taking on this review for JOSE (the Journal of Open Source Education) ? This submission is about implicit methods for CFD and uses Python and Jupyter: this overlaps some of the expertise JOSE has listed for you, and I think you would be an excellent reviewer. Please see the JOSE reviewer guidelines for details about the JOSE review process.

Title: A course on the implicit finite volume method for CFD using Python
Summary: .A course on Computational Fluid Dynamics using Jupyter Notebooks and Python
Article Proof: https://github.com/openjournals/jose-papers/blob/jose.00066/jose.00066/10.21105.jose.00066.pdf
Submitting author: @ctdegroot (Chris DeGroot)
Repository: https://bitbucket.org/cdegroot/cfdcourse

@sconde
Copy link
Collaborator

sconde commented Aug 10, 2019

Sidafa Conde, are you able to and interested in taking on this review for JOSE (the Journal of Open Source Education)

@IanHawke I accept

@IanHawke
Copy link

Thank you @sconde ! The review will take place in another issue thread that will launch as soon as we have a second reviewer, but if you want to start the review already then feel free to link any issues that you create to this thread for now.

@whedon assign @sconde as reviewer

@labarba
Copy link
Member

labarba commented Aug 10, 2019

@whedon assign @sconde as reviewer

@whedon whedon assigned IanHawke and sconde and unassigned IanHawke Aug 10, 2019
@whedon
Copy link
Author

whedon commented Aug 10, 2019

OK, the reviewer is @sconde

@labarba
Copy link
Member

labarba commented Aug 10, 2019

👋 @IanHawke@whedon likes its commands to come alone in a comment :–)

@zingale
Copy link
Collaborator

zingale commented Aug 10, 2019

I can do a review too. I'll be a little slow this week, but can finish the following.

@IanHawke
Copy link

@zingale : Thanks! Very happy that you can contribute to this.

@IanHawke
Copy link

@whedon add @zingale as reviewer

@whedon
Copy link
Author

whedon commented Aug 11, 2019

OK, @zingale is now a reviewer

@IanHawke
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 11, 2019

OK, I've started the review over in #67. Feel free to close this issue now!

@IanHawke
Copy link

@sconde , @zingale : the review issue is now started at #67 . There is a detailed checklist there. Thanks for your help with this review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants