-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: An R Companion for Introduction to Data Mining #223
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
Wordcount for |
Thank you both @hughshanahan and @rudeboybert for agreeing to review this submission. Let's aim to complete your checklists by March 15th, 2024. |
Hello @hughshanahan and @rudeboybert, this is a friendly reminder to review this submission. Thank you! |
Hello @hughshanahan, are you able to review this? |
Hello @rudeboybert, are you able to review this? |
So sorry @stats-tgeorge to have dropped the ball on this. It was a brutal semester. Do you still need this? If so, I can get it to you by the evening of Thu 6/30. |
Hello @rudeboybert. I am sorry to hear of the rough semester. I'm sure you are excited about summer then! I am still looking for people to review this. This is also my area so I can be a reviewer if necessary. I may see if others are available now that it is summer. Thank you for following up! |
Review checklist for @rudeboybertConflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
|
@mhahsler a few outstanding items need to be addressed in my checklist above |
@rudeboybert Thank you for the review. I have addressed the three issues:
I am not sure if creating the release is sufficient to address "Version: Does the release version given match the repository release?". Best regards, |
@editorialbot remove @hughshanahan as reviewer |
@hughshanahan removed from the reviewers list! |
@editorialbot add @stats-tgeorge as reviewer |
@stats-tgeorge added to the reviewers list! |
@editorialbot commands |
Hello @stats-tgeorge, here are the things you can ask me to do:
|
Review checklist for @stats-tgeorgeConflict of interest
Code of Conduct
General checks
Documentation
Pedagogy / Instructional design (Work-in-progress: reviewers, please comment!)
JOSE paper
|
@editorialbot check repository |
Software report:
Commit count by author:
|
Paper file info: 📄 Wordcount for ✅ The paper includes a |
@stats-tgeorge Additional Author Tasks After Review is Complete
Version Number: 1.0.1 (https://github.com/mhahsler/Introduction_to_Data_Mining_R_Examples/releases/tag/1.0.1) |
@editorialbot generate pdf |
@editorialbot set 10.6084/m9.figshare.26750404.v1 as archive |
Done! archive is now 10.6084/m9.figshare.26750404.v1 |
@editorialbot set 1.0.1 as version |
Done! version is now 1.0.1 |
@editorialbot generate pdf |
@mhahsler the DOI needs updating on the JOSE paper. Once that is fixed I will recommend accepting. |
@stats-tgeorge That is geat news! Thanks for helping me through this process. About the DOI: I assume you are asking for this missing DOI
The referenced book is Tan, P.-N., Steinbach, M. S., Karpatne, A., & Kumar, V. (2017). Introduction to data The suggested DOI is for a different book: Discovering Knowledge in Data: An Introduction to Data Mining It seems like not all books have assigned DOIs. There is no DOI on the publisher's page I also cannot find one registered with crossref As far as I can tell, the book does not have a DOI at this point. |
Good morning! It's what I'm here for - I am sorry this took so long! I saw you mentioned that DOI before. I am referring to the DOI on the left side of the rendered JOSE paper. Looks like you had a placeholder there. |
@mhahsler This is my misunderstanding. That DOI is assigned once accepted. Working on moving forward! |
@openjournals/jose-eics I believe we are ready to move forward to publish. TY! |
@openjournals/jose-eics Hi. Is there anything that I need to do? |
@stats-tgeorge Hi George. Is the @openjournals/jose-eics handle correct? |
@mhahsler It links to our EIC so it appears to work correctly. I know she is very backed up at the moment. |
Thanks for letting me know. |
@editorialbot recommend-accept |
|
|
👋 @openjournals/jose-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/jose-papers#160, then you can now move forward with accepting the submission by compiling again with the command |
You were correct. I was following our guide (which suggested what I did) and not my checklist. My mistake. |
Should the archive DOI be updated to |
It looks like version 2 was created after the DOI was updated here. Yes, it now needs to be updated again. |
I'm confused. This archive:
...contains a 357-page PDF.
In the JOSE paper, it says that the materials are available at https://mhahsler.github.io/Introduction_to_Data_Mining_R_Examples/book/ The "View book source" button sends me to this GitHub repo: https://github.com/mhahsler/Introduction_to_Data_Mining_R_Examples So why don't we have as the archive a deposit of the GitHub repository, which is in fact the source for the book? If a user wants to fork and modify, they need the source. I also notice that the Figshare deposit (both versions) show a CC-BY license, while the website and GitHub repo indicate CC-BY-SA. Shouldn't the licenses be the same? (I realize these are different objects, per my inquiry above, but still…) |
I notice the comment above where the author says:
The online book shows a CC-BY license, so this matches. I had seen on the repository a CC-BY-SA license, but the author has just changed it. Indeed, the license should match everywhere. The issue remains that the archive on Figshare is a collection of website files (v1) or a PDF (v2). What JOSE wants is an archive of the source, which is the only thing that guarantees future reuse and derivative works. Having a Fighsare deposit of the PDF is nice (users can immediately read), but it is not conducive to derivative works. I would suggest a Zenodo deposit of the GitHub repo. If the author prefers Figshare, then a zip of the repo is the only way. |
@labarba and @stats-tgeorge: I agree this isn't very clear. I have now done the following:
@labarba Please let me know if I should update the paper in my GitHub repository. BTW: I tried Zenodo first, but it did not like the repository with so many non-code files and died in the process of importing the repository. Thanks for your help, |
Submitting author: @mhahsler (Michael Hahsler)
Repository: https://github.com/mhahsler/Introduction_to_Data_Mining_R_Examples
Branch with paper.md (empty if default branch):
Version: 1.0.1
Editor: @stats-tgeorge
Reviewers: @rudeboybert, @stats-tgeorge
Archive: 10.6084/m9.figshare.26750404.v1
Paper kind: learning module
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@hughshanahan & @rudeboybert, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://openjournals.readthedocs.io/en/jose/reviewer_guidelines.html. Any questions/concerns please let @stats-tgeorge know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @rudeboybert
📝 Checklist for @stats-tgeorge
The text was updated successfully, but these errors were encountered: