Update javafxplugin and jlink versions to support newer versions of java #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Need to increase javafxplugin version because of a bug exist for build with java11+ in moduleplugin which used in older versions of javafxplugin. It is fixed by openjfx/javafx-gradle-plugin#120 Which in merged with 0.0.12 * Need to increase jlink because of a bug exist in jlink for building java16 versions ( beryx/badass-jlink-plugin#176 )
usta
changed the title
|
@jdneo @jperedadnr @abhinayagarwal I will be glad to get a review for this PR/MR , thank you |
|
This PR is outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to increase javafxplugin version because of a bug exist for build with java11+ in moduleplugin which used in older versions of javafxplugin. It is fixed by Update moduleplugin to v1.8.10 javafx-gradle-plugin#120 Which in merged with 0.0.12
Need to increase jlink because of a bug exist in jlink for building java16 versions ( Problems with JDK16: Unsupported major.minor version 60.0 beryx/badass-jlink-plugin#176 )