Skip to content

WhitespaceCheck as warning #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: testSKARA
Choose a base branch
from

Conversation

zhaosongzs
Copy link
Member

@zhaosongzs zhaosongzs commented May 28, 2025

Test whitespace check as warning


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed (1 review required, with at least 1 Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/playground.git pull/225/head:pull/225
$ git checkout pull/225

Update a local copy of the PR:
$ git checkout pull/225
$ git pull https://git.openjdk.org/playground.git pull/225/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 225

View PR using the GUI difftool:
$ git pr show -t 225

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/playground/pull/225.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

👋 Welcome back zsong! A progress list of the required criteria for merging this PR into testSKARA will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@zhaosongzs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

WhitespaceCheck as warning

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the testSKARA branch:

Please see this link for an up-to-date comparison between the source branch of this pull request and the testSKARA branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the testSKARA branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@zhaosongzs To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@mlbridge
Copy link

mlbridge bot commented May 28, 2025

Webrevs

@zhaosongzs zhaosongzs changed the title trailing space trailing space as warnings May 28, 2025
@zhaosongzs zhaosongzs changed the title trailing space as warnings WhitespaceCheck as warning May 28, 2025
@zhaosongzs
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented May 28, 2025

@zhaosongzs The pull request is being re-evaluated and the inactivity timeout has been reset.

@zhaosongzs
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented May 28, 2025

@zhaosongzs The pull request is being re-evaluated and the inactivity timeout has been reset.

@zhaosongzs
Copy link
Member Author

/touch

@openjdk
Copy link

openjdk bot commented May 29, 2025

@zhaosongzs The pull request is being re-evaluated and the inactivity timeout has been reset.

@zhaosongzs zhaosongzs closed this May 29, 2025
@zhaosongzs zhaosongzs reopened this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant