Skip to content

Conversation

@arapte
Copy link
Member

@arapte arapte commented Feb 11, 2026

On a given platform, the build generates prism and decora shader files for all platforms.
Ideally it should generate only the platform specific shader files.

Fix:
Generate only platform specific hardware shaders.
sw pipeline shaders must be generated for all platforms.
But hardware shaders:

  1. Mac platform : metal and es2 shaders
  2. Win platform: d3d shaders andif IS_INCLUDE_ES2 is true then es2 shaders as well
  3. Linux : only es2 shaders

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357625: Build should generate platform specific shaders (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2071/head:pull/2071
$ git checkout pull/2071

Update a local copy of the PR:
$ git checkout pull/2071
$ git pull https://git.openjdk.org/jfx.git pull/2071/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2071

View PR using the GUI difftool:
$ git pr show -t 2071

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2071.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2026

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 11, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant