8357625: Build should generate platform specific shaders #2071
+30
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a given platform, the build generates prism and decora shader files for all platforms.
Ideally it should generate only the platform specific shader files.
Fix:
Generate only platform specific hardware shaders.
sw pipeline shaders must be generated for all platforms.
But hardware shaders:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2071/head:pull/2071$ git checkout pull/2071Update a local copy of the PR:
$ git checkout pull/2071$ git pull https://git.openjdk.org/jfx.git pull/2071/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2071View PR using the GUI difftool:
$ git pr show -t 2071Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2071.diff