Skip to content

Conversation

@HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Feb 4, 2026

This PR updates webkit to v2.50.4. Verified build and sanity on mac, windows and linux platforms. No issue seen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8377099: Additional WebKit 623.1 fixes from WebKitGTK 2.50.4 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2063/head:pull/2063
$ git checkout pull/2063

Update a local copy of the PR:
$ git checkout pull/2063
$ git pull https://git.openjdk.org/jfx.git pull/2063/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2063

View PR using the GUI difftool:
$ git pr show -t 2063

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2063.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2026

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8377099: Additional WebKit 623.1 fixes from WebKitGTK 2.50.4

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@HimaBinduMeda HimaBinduMeda marked this pull request as ready for review February 4, 2026 16:27
@openjdk openjdk bot added the rfr Ready for review label Feb 4, 2026
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2026

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen

/reviewers 2

@openjdk
Copy link

openjdk bot commented Feb 4, 2026

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My sanity testing is green.

@victordyakov
Copy link
Collaborator

@tiainen please review

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds went fine.

@openjdk openjdk bot added the ready Ready to be integrated label Feb 11, 2026
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 11, 2026

Going to push as commit 7f012ba.
Since your change was applied there have been 5 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 11, 2026
@openjdk openjdk bot closed this Feb 11, 2026
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Feb 11, 2026
@openjdk
Copy link

openjdk bot commented Feb 11, 2026

@HimaBinduMeda Pushed as commit 7f012ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants