Skip to content

Transparent background fill for StageStyle.EXTENDED windows #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
crschnick wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Draft

Transparent background fill for StageStyle.EXTENDED windows #2045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassScene.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,8 @@ protected Color getClearColor() {
return Color.WHITE;
} else if (fillPaint.isOpaque() ||
(windowStage != null && windowStage.getPlatformWindow() != null &&
windowStage.getPlatformWindow().isUnifiedWindow())) {
(windowStage.getPlatformWindow().isUnifiedWindow() ||
windowStage.getPlatformWindow().isExtendedWindow()))) {
//For bare windows the transparent fill is allowed
if (fillPaint.getType() == Paint.Type.COLOR) {
return (Color)fillPaint;
Expand Down
2 changes: 1 addition & 1 deletion modules/javafx.graphics/src/main/native-glass/win/GlassWindow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,7 @@ LRESULT GlassWindow::WindowProc(UINT msg, WPARAM wParam, LPARAM lParam)
}
break;
case WM_DWMCOMPOSITIONCHANGED:
if (m_isUnified && (IS_WINVISTA)) {
if ((m_isUnified || m_isExtended) && (IS_WINVISTA)) {
BOOL bEnabled = FALSE;
if(SUCCEEDED(::DwmIsCompositionEnabled(&bEnabled)) && bEnabled) {
MARGINS dwmMargins = { -1, -1, -1, -1 };
Expand Down