Skip to content

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Dec 17, 2025

Updates the RichTextArea code to use the new text layout APIs delivered in https://bugs.openjdk.org/browse/JDK-8341670

Also:

  • updates the "demo" model in the RichTextAreaDemoApp to show underline/strikethrough in the presence of TextFlow borders

/reviewers 2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8370902: RichTextArea: migrate to new text APIs (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/2012/head:pull/2012
$ git checkout pull/2012

Update a local copy of the PR:
$ git checkout pull/2012
$ git pull https://git.openjdk.org/jfx.git pull/2012/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2012

View PR using the GUI difftool:
$ git pr show -t 2012

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/2012.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jan 15, 2026

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review January 15, 2026 23:09
@openjdk openjdk bot added the rfr Ready for review label Jan 15, 2026
@mlbridge
Copy link

mlbridge bot commented Jan 15, 2026

Webrevs

@andy-goryachev-oracle
Copy link
Contributor Author

@Ziad-Mid could you be the second reviewer please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants