Skip to content

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Nov 4, 2025

Fixes an issue found by an external user:

Undoing a style only change fires a change event where ContentChange.isEdit is true when it should be false.

NOTE


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371183: RichTextModel: ContentChange.isEdit incorrect undoing style modification (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1961/head:pull/1961
$ git checkout pull/1961

Update a local copy of the PR:
$ git checkout pull/1961
$ git pull https://git.openjdk.org/jfx.git pull/1961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1961

View PR using the GUI difftool:
$ git pr show -t 1961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1961.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 4, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 4, 2025

⚠️ @andy-goryachev-oracle This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant