-
Notifications
You must be signed in to change notification settings - Fork 543
8371183: RichTextModel: ContentChange.isEdit incorrect undoing style modification #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8371183: RichTextModel: ContentChange.isEdit incorrect undoing style modification #1961
Conversation
Co-authored-by: Kevin Rushforth <kevin.rushforth@oracle.com>
|
👋 Welcome back angorya! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
|
Fixes an issue found by an external user:
Undoing a style only change fires a change event where
ContentChange.isEditis true when it should be false.NOTE
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1961/head:pull/1961$ git checkout pull/1961Update a local copy of the PR:
$ git checkout pull/1961$ git pull https://git.openjdk.org/jfx.git pull/1961/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1961View PR using the GUI difftool:
$ git pr show -t 1961Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1961.diff