8371087: Remove unused dependency on jdk.unsupported from javafx.graphics

[kevinrushforth]

This PR removes the unused dependency on jdk.unsupported from javafx.graphics as a followup to JDK-8334137, which replaced the use of sun.misc.Unsafe with FFM in PR #1814. sun.misc.Unsafe was the only use of jdk.unsupported, so it can now be removed.

It also removes the no-longer-needed -XDignore.symbol.file flag from build.gradle.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8371087: Remove unused dependency on jdk.unsupported from javafx.graphics (Bug - P4)
• JDK-8179462: Remove obsolete -XDignore.symbol.file flag from build (Bug - P4)

Reviewers

• Marius Hanl (@Maran23 - Committer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1957/head:pull/1957
$ git checkout pull/1957

Update a local copy of the PR:
$ git checkout pull/1957
$ git pull https://git.openjdk.org/jfx.git pull/1957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1957

View PR using the GUI difftool:
$ git pr show -t 1957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1957.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371087: Remove unused dependency on jdk.unsupported from javafx.graphics
8179462: Remove obsolete -XDignore.symbol.file flag from build

Reviewed-by: mhanl, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (fe26e6fc)
• 00: Full (e390af9a)

[bourgesl]

LGTM.
Good job!

[Maran23]

Makes sense. Can confirm that the last sun.misc usage is WebEngine.java in the android folder in javafx.web, as also noted in the comment in #1814 (comment).

[AnirvanSarkar]

As sun.misc.Unsafe is not used anymore, maybe then also remove the references to XDignore.symbol.file flag in build.gradle.

I noticed JDK-8179462 already exists to remove the flag from javadoc build.

[Maran23]

As sun.misc.Unsafe is not used anymore, maybe then also remove the references to XDignore.symbol.file flag in build.gradle.

I noticed JDK-8179462 already exists to remove the flag from javadoc build.

That sounds indeed reasonable! As mentioned above, there is one sun.misc usage left in the android folder, so we may need to check that out first.

[kevinrushforth]

As sun.misc.Unsafe is not used anymore, maybe then also remove the references to XDignore.symbol.file flag in build.gradle.
I noticed JDK-8179462 already exists to remove the flag from javadoc build.

That sounds indeed reasonable!

Agreed. I'll expand JDK-8179462 to remove -XDignore.symbol.file entirely, both as a javadoc and javac option and then add that issue to this PR.

As mentioned above, there is one sun.misc usage left in the android folder, so we may need to check that out first.

Since that file cannot possibly compile without some additional modification to the JDK and/or JavaFX anyway, I don't see any harm removing this option from build.gradle. The right fix for the obsolete sun.misc usage in the android folder would be to replace sun.misc.BASE64Encoder with java.util.Base64 as we did for the rest of JavaFX. I'll file a follow-on bug for that.

[kevinrushforth]

/issue add 8179462

[openjdk]

@kevinrushforth
Adding additional issue to issue list: 8179462: Remove obsolete -XDignore.symbol.file flag from build.

[kevinrushforth]

I filed JDK-8371157 to track replacing the obsolete usage of sun.misc.BASE64Encoder in the android dir.

I also filed JDK-8371158 as a follow-on to investigate removing a workaround for setting javac options that is described as only being needed so we can set -XDignore.symbol.file.

[kevinrushforth]

@arapte Can you be the primary Reviewer?

[bourgesl]

Good job!

[arapte]

lgtm

[kevinrushforth]

/integrate

[openjdk]

Going to push as commit a4e5451.

[openjdk]

@kevinrushforth Pushed as commit a4e5451.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.