8368631: Avoid updating disposed MTLTexture

[arapte]

Issue:
Calling MTLTexture.update() method on a disposed MTLTexture object would cause a crash.
The root cause of this behavior is JDK-8368629.

Fix:
Avoid MTLTexture.update() if texture is disposed.
The crash should be fixed now and the root cause will be followed up using JDK-8368629

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8368631: Avoid updating disposed MTLTexture (Bug - P2)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ajit Ghaisas (@aghaisas - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1919/head:pull/1919
$ git checkout pull/1919

Update a local copy of the PR:
$ git checkout pull/1919
$ git pull https://git.openjdk.org/jfx.git pull/1919/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1919

View PR using the GUI difftool:
$ git pr show -t 1919

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1919.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368631: Avoid updating disposed MTLTexture

Reviewed-by: kcr, aghaisas

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (dddbf8fb)

[kevinrushforth]

Reviewers: @kevinrushforth @aghaisas

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

LGTM

[aghaisas]

Looks good.

[arapte]

/integrate

[openjdk]

Going to push as commit c480b46.

[openjdk]

@arapte Pushed as commit c480b46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.