8358820: Allow interpolation outside of range [0,1] #1822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaFX unnecessarily restricts interpolation in the following ways:
Interpolatable
implementations often clamp intermediate values to the interpolation factor range [0,1].SplineInterpolator
doesn't accept Y coordinates outside of [0,1] for its control points. While this was probably done so that the computed interpolation factor doesn't exceed [0,1], the restriction goes far beyond that. For example, the following function is not representable, even though its values are all within the [0,1] range:The following function is also not representable, but would be very useful for bouncy animations:
Fortunately, there is no technical reason why JavaFX can't support the full range of animations that can be represented with a cubic Beziér interpolation function.
This PR includes the following changes:
Interpolatable
is changed to require implementations to accept interpolation factors outside of [0,1].Interpolatable
now correctly return intermediate values outside of [0,1].SplineInterpolator
now accepts control points with any Y coordinate.Here's how the result looks like for the previously unrepresentable interpolation function

cubic-bezier(0.34, 2.2, 0.64, 1)
:/reviewers 2
/csr
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1822/head:pull/1822
$ git checkout pull/1822
Update a local copy of the PR:
$ git checkout pull/1822
$ git pull https://git.openjdk.org/jfx.git pull/1822/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1822
View PR using the GUI difftool:
$ git pr show -t 1822
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1822.diff
Using Webrev
Link to Webrev Comment