8358770: incubator.richtext pom missing dependency on incubator.input #1821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a missing maven dependency for
jfx.incubator.richtext
on thejfx.incubator.input
module. The dependency is correctly present in themodule-info.java
ofjfx.incubator.richtext
as well as the gradle dependency for the project. It's only the maven dependency that is missing. While fixing this, I noticed that there is an unnecessary maven dependency in theincubator.richtext
andincubator.input
projects on thegraphics
project. Both projects already listcontrols
, so do not need to listgraphics
orbase
(see thefxml
andweb
projects for comparison).Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1821/head:pull/1821
$ git checkout pull/1821
Update a local copy of the PR:
$ git checkout pull/1821
$ git pull https://git.openjdk.org/jfx.git pull/1821/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1821
View PR using the GUI difftool:
$ git pr show -t 1821
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1821.diff
Using Webrev
Link to Webrev Comment