Skip to content

8358770: incubator.richtext pom missing dependency on incubator.input #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jun 6, 2025

This PR adds a missing maven dependency for jfx.incubator.richtext on the jfx.incubator.input module. The dependency is correctly present in the module-info.java of jfx.incubator.richtext as well as the gradle dependency for the project. It's only the maven dependency that is missing. While fixing this, I noticed that there is an unnecessary maven dependency in the incubator.richtext and incubator.input projects on the graphics project. Both projects already list controls, so do not need to list graphics or base (see the fxml and web projects for comparison).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8358770: incubator.richtext pom missing dependency on incubator.input (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1821/head:pull/1821
$ git checkout pull/1821

Update a local copy of the PR:
$ git checkout pull/1821
$ git pull https://git.openjdk.org/jfx.git pull/1821/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1821

View PR using the GUI difftool:
$ git pr show -t 1821

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1821.diff

Using Webrev

Link to Webrev Comment

@kevinrushforth
Copy link
Member Author

Reviewers: @andy-goryachev-oracle @tiainen

/reviewers 2

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 6, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 6, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth kevinrushforth changed the title incubator.richtext pom missing dependency on incubator.input 8358770: incubator.richtext pom missing dependency on incubator.input Jun 6, 2025
@openjdk openjdk bot added the rfr Ready for review label Jun 6, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 6, 2025

Webrevs

@jeffalder
Copy link

jeffalder commented Jun 7, 2025

Awesome! I submitted the JBS; thanks for hopping on this so fast.

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't build maven artifacts, but the changes look right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

3 participants