8318985: [macos] Incorrect 3D lighting on macOS 14 and later

[jayathirthrao]

When no specular color is set while rendering 3D primitives, 0.0 specular power value is used by default in our shaders.
When same specular power value is used in pow() function in shader it results in undefined behaviour as mentioned at : https://registry.khronos.org/OpenGL-Refpages/es3.0/html/pow.xhtml

By default specular power value should be 32, so now the specular_none.frag file is updated to use this default value to make sure we don't see 3D lighting issues on some platforms. This change is tested with Ensemble8 and fx83dfeatures and i don't see any regressions.

Also one of our system test PointLightIlluminationTest used to fail because of this issue. It passes now with this update and it is re-enabled.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8318985: [macos] Incorrect 3D lighting on macOS 14 and later (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1791/head:pull/1791
$ git checkout pull/1791

Update a local copy of the PR:
$ git checkout pull/1791
$ git pull https://git.openjdk.org/jfx.git pull/1791/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1791

View PR using the GUI difftool:
$ git pr show -t 1791

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1791.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8318985: [macos] Incorrect 3D lighting on macOS 14 and later

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 4df2326: 8352162: Update libxml2 to 2.13.8
• 46b36fe: 8354876: Update SQLite to 3.49.1
• d1fcca7: 8329227: Seek might hang with fMP4 H.265/HEVC or H.265/HEVC over HTTP/FILE
• ... and 1 more: https://git.openjdk.org/jfx/compare/a25935d1b2778223901cec0d07b3f2f4d4be665b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (fe50169e)

[arapte]

/reviewers 2

[openjdk]

@arapte
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[arapte]

@jayathirthrao
Does this change has any effect on Linux platform ?

[jayathirthrao]

@arapte I have run all headful system tests in CI on linux and it is green.
This change will effect all platforms where OpenGL will be used, but not using 0.0 in pow() on all platforms is right thing to do.

Just to be sure i will also run Ensemble8 in Linux and update.

[kevinrushforth]

Reviewers: @arapte @kevinrushforth

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

LGTM. On my macOS 14.x M1 system, the re-enabled test fails without the fix and passes with the fix. It looks visually correct now.

I didn't test it on Linux, so I'll rely on others to do that.

[arapte]

LGTM. Tested on mac and windows(with es2 pipeline) platform.
Shall rely @jayathirthrao for Linux sanity testing.

[arapte]

Please wait for 24 hours before integrating.

[jayathirthrao]

@arapte I have run all headful system tests in CI on linux and it is green. This change will effect all platforms where OpenGL will be used, but not using 0.0 in pow() on all platforms is right thing to do.

Just to be sure i will also run Ensemble8 in Linux and update.

I have verified Ensemble8 3D demos(played around with specular parameters in 3DSphere demo) on Ubuntu 24.04 and i don't see any issues.

[jayathirthrao]

/integrate

[openjdk]

Going to push as commit 2617ff5.
Since your change was applied there have been 7 commits pushed to the master branch:

• c0b798b: 8355413: Re-enable InitializeJavaFXLaunchTests on Xorg
• 1b2f022: 8347359: RichTextArea API Tests
• 1a12966: 8354478: Improve StageStyle documentation
• ... and 4 more: https://git.openjdk.org/jfx/compare/a25935d1b2778223901cec0d07b3f2f4d4be665b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jayathirthrao Pushed as commit 2617ff5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.