-
Notifications
You must be signed in to change notification settings - Fork 162
8349166: Bad indentation in backport of JDK-8250825 #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. Sorry for the delay in getting back to this.
|
/approval request Fix the bad indentation after backport of JDK-8250825, trivial fix, all the GHA failures unrelated to this PR. |
@sendaoYan |
/approve yes |
@gnu-andrew |
Thanks @gnu-andrew /integrate |
@sendaoYan |
/sponsor |
Going to push as commit f5e9a25.
Your commit was automatically rebased without conflicts. |
@gnu-andrew @sendaoYan Pushed as commit f5e9a25. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This PR fix the bad indentation in backport of JDK-8250825.
Trivial fix, no risk.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/619/head:pull/619
$ git checkout pull/619
Update a local copy of the PR:
$ git checkout pull/619
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/619/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 619
View PR using the GUI difftool:
$ git pr show -t 619
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/619.diff
Using Webrev
Link to Webrev Comment