Skip to content

8349166: Bad indentation in backport of JDK-8250825 #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Feb 1, 2025

Hi all,
This PR fix the bad indentation in backport of JDK-8250825.
Trivial fix, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8349166 needs maintainer approval

Issue

  • JDK-8349166: Bad indentation in backport of JDK-8250825 (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/619/head:pull/619
$ git checkout pull/619

Update a local copy of the PR:
$ git checkout pull/619
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 619

View PR using the GUI difftool:
$ git pr show -t 619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/619.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 1, 2025

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8349166: Bad indentation in backport of JDK-8250825

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2025

Webrevs

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Sorry for the delay in getting back to this.

@openjdk
Copy link

openjdk bot commented Feb 19, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

sendaoYan commented Feb 20, 2025

/approval request Fix the bad indentation after backport of JDK-8250825, trivial fix, all the GHA failures unrelated to this PR.

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@sendaoYan
8349166: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Feb 20, 2025
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@gnu-andrew
8349166: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 20, 2025
@sendaoYan
Copy link
Member Author

Thanks @gnu-andrew

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@sendaoYan
Your change (at version 1453502) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 20, 2025

Going to push as commit f5e9a25.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
  • 88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
  • 4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 20, 2025
@openjdk openjdk bot closed this Feb 20, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 20, 2025
@openjdk
Copy link

openjdk bot commented Feb 20, 2025

@gnu-andrew @sendaoYan Pushed as commit f5e9a25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8349166 branch February 20, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants