8193682: Infinite loop in ZipOutputStream.close()

[yan-too]

This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker.

The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues.

There will be a second fix in this series, JDK-8278794.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8283331 to be approved
• JDK-8193682 needs maintainer approval

Issues

• JDK-8193682: Infinite loop in ZipOutputStream.close() (Bug - P4 - Approved)
• JDK-8283331: Infinite loop in ZipOutputStream.close() (CSR)

Reviewers

• Severin Gehwolf (@jerboaa - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/558/head:pull/558
$ git checkout pull/558

Update a local copy of the PR:
$ git checkout pull/558
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/558/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 558

View PR using the GUI difftool:
$ git pr show -t 558

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/558.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8193682: Infinite loop in ZipOutputStream.close()

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• edbdf05: 8336928: GHA: Bundle artifacts removal broken
• 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
• ea76f37: 8338144: [8u] Remove duplicate license files
• fb0a658: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir
• 4538bba: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (2c224688)
• 01: Full - Incremental (f68b0a11)
• 00: Full (953a0aaa)

[yan-too]

Most pre-submit failures are unrelated, even build failures on Windows x86 -- but these are my debt from July release, 8320097, isinf/isnan not sufficiently covered in this case.

[jerboaa]

Looks OK to me.

[openjdk]

⚠️ @yan-too This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[yan-too]

Thank you Severin!

macOS test failures are connection problems, apparently.
Windows x86 does pass after JDK-8337312, thank you Andrew. I'm sorry I was too slow to fix it :-(

[jerboaa]

macOS test failures are connection problems, apparently.

Yes. Known issues. See: #544 (comment)

[yan-too]

/integrate

[openjdk]

Going to push as commit 8867d01.
Since your change was applied there have been 13 commits pushed to the master branch:

• 5c7f201: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50"
• 933c78e: 8309138: Fix container tests for jdks with symlinked conf dir
• 4fe22e8: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows.
• 855480b: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690
• 4c9c5a4: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails
• 8b28c35: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java
• 2afd918: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
• 439e910: 8321480: ISO 4217 Amendment 176 Update
• edbdf05: 8336928: GHA: Bundle artifacts removal broken
• 1ca84ad: 8305400: ISO 4217 Amendment 175 Update
• ... and 3 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e0ae42d644e45c6eab9037874110ed670...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too Pushed as commit 8867d01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.