8244966: Add .vscode to .hgignore and .gitignore #556

sendaoYan · 2024-07-30T15:11:18Z

Hi all,

This pull request contains a backport of commit 95c0b97b from the openjdk/jdk11u-dev repository.

The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee.

Trivial fix but useful, no risk.

Thanks!

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8244966 needs maintainer approval

Issue

JDK-8244966: Add .vscode to .hgignore and .gitignore (Enhancement - P5 - Approved)

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/556/head:pull/556
$ git checkout pull/556

Update a local copy of the PR:
$ git checkout pull/556
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 556

View PR using the GUI difftool:
$ git pr show -t 556

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/556.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-07-30T15:11:48Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-07-30T15:12:41Z

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8244966: Add .vscode to .hgignore and .gitignore

Add .vscode to .hgignore and .gitignore

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 85 new commits pushed to the master branch:

f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
492acd3: 8265019: Update tests for additional TestNG test permissions
3683a81: Merge
129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
... and 75 more: https://git.openjdk.org/jdk8u-dev/compare/0e7148dbfab4b01bdcb615eb2e8d217a47d6874e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-07-30T15:12:53Z

This backport pull request has now been updated with issue and summary from the original commit.

openjdk · 2024-07-30T15:13:28Z

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

sendaoYan · 2024-07-30T15:14:02Z

/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix but useful, no risk.

openjdk · 2024-07-30T15:14:48Z

@sendaoYan
8244966: The approval request has been created successfully.

mlbridge · 2024-07-30T15:18:43Z

Webrevs

00: Full (a0092275)

bridgekeeper · 2024-08-27T17:24:26Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-08-28T02:22:36Z

Hi all, does this backport useful to jdk8u-dev.

sendaoYan · 2024-08-28T03:45:09Z

The GHA report several failures, all the failures are unreleated to this PR.

windows x86 build fails _isnan referenced in function _checkOverflow which has been recorded and fixed by JDK-8337312
macosx-64 jdk/tier1 report com/sun/jdi tests fails, transport error 202: gethostbyname: unknown host seems to be GHA environmental issue.
macos-x64 hotpsot/tier1 report OpaqueAccesses.java fails, which has been recorded by JDK-8337185
macos-x64 hotpsot/tier1 report FieldMonitor.java fails, same to 2
All the fails are CA test fails, which fixing by 8334441: Mark tests in jdk_security_infra group as manual #526

bridgekeeper · 2024-09-25T06:36:44Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-09-25T07:39:38Z

/open

openjdk · 2024-09-25T07:40:05Z

@sendaoYan This pull request is already open

bridgekeeper · 2024-10-23T10:52:50Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2024-10-31T03:19:03Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-10-31T03:26:07Z

/approval request Backport JDK-8244966 to add .vscode to .gitignore. Trivial fix but useful, no risk.

openjdk · 2024-10-31T03:27:03Z

@sendaoYan
8244966: The approval request was already up to date.

sendaoYan · 2025-01-31T04:27:38Z

/open

sendaoYan · 2025-01-31T04:27:53Z

/open

openjdk · 2025-01-31T04:28:59Z

@sendaoYan This pull request is now open

openjdk · 2025-01-31T04:29:40Z

@sendaoYan This pull request is already open

sendaoYan · 2025-02-25T06:09:19Z

@mrserb Thanks for the approved.

/approval request Clean backport to add .vscode to .hgignore and .gitignore. Trivial fix but useful, no risk.

openjdk · 2025-02-25T06:10:09Z

@sendaoYan
8244966: The approval request has been updated successfully.

sendaoYan · 2025-02-25T10:09:57Z

Thanks for approved.

/integrate

openjdk · 2025-02-25T10:10:58Z

@sendaoYan
Your change (at version a009227) is now ready to be sponsored by a Committer.

zzambers · 2025-02-25T13:04:06Z

/sponsor

openjdk · 2025-02-25T13:05:20Z

Going to push as commit 85fb26b.
Since your change was applied there have been 86 commits pushed to the master branch:

5ccff2c: 8348211: [8u] sun/management/jmxremote/startstop/JMXStartStopTest.java fails after backport of JDK-8066708
f5e9a25: 8349166: Bad indentation in backport of JDK-8250825
fc88d51: 8255466: C2 crashes at ciObject::get_oop() const+0x0
88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
8b08668: 8250825: C2 crashes with assert(field != __null) failed: missing field
bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
492acd3: 8265019: Update tests for additional TestNG test permissions
3683a81: Merge
... and 76 more: https://git.openjdk.org/jdk8u-dev/compare/0e7148dbfab4b01bdcb615eb2e8d217a47d6874e...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-02-25T13:05:29Z

@zzambers @sendaoYan Pushed as commit 85fb26b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

sendaoYan · 2025-02-25T13:15:55Z

/sponsor

Thanks.

Backport 95c0b97bc2bfcb686dfabc6d74424772f0f866a1

a009227

openjdk bot changed the title ~~Backport 95c0b97bc2bfcb686dfabc6d74424772f0f866a1~~ 8244966: Add .vscode to .hgignore and .gitignore Jul 30, 2024

openjdk bot added backport clean labels Jul 30, 2024

openjdk bot added the rfr Pull request is ready for review label Jul 30, 2024

openjdk bot added the approval label Jul 30, 2024

sendaoYan closed this Nov 21, 2024

openjdk bot reopened this Jan 31, 2025

openjdk bot removed the approval label Jan 31, 2025

mrserb approved these changes Feb 25, 2025

View reviewed changes

openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Feb 25, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 25, 2025

openjdk bot added the integrated Pull request has been integrated label Feb 25, 2025

openjdk bot closed this Feb 25, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 25, 2025

8244966: Add .vscode to .hgignore and .gitignore #556

8244966: Add .vscode to .hgignore and .gitignore #556

Uh oh!

Conversation

sendaoYan commented Jul 30, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 30, 2024

Uh oh!

openjdk bot commented Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jul 30, 2024

Uh oh!

openjdk bot commented Jul 30, 2024

Uh oh!

sendaoYan commented Jul 30, 2024

Uh oh!

openjdk bot commented Jul 30, 2024

Uh oh!

mlbridge bot commented Jul 30, 2024

Webrevs

Uh oh!

bridgekeeper bot commented Aug 27, 2024

Uh oh!

sendaoYan commented Aug 28, 2024

Uh oh!

sendaoYan commented Aug 28, 2024

Uh oh!

bridgekeeper bot commented Sep 25, 2024

Uh oh!

sendaoYan commented Sep 25, 2024

Uh oh!

openjdk bot commented Sep 25, 2024

Uh oh!

bridgekeeper bot commented Oct 23, 2024

Uh oh!

bridgekeeper bot commented Oct 31, 2024

Uh oh!

sendaoYan commented Oct 31, 2024

Uh oh!

openjdk bot commented Oct 31, 2024

Uh oh!

sendaoYan commented Jan 31, 2025

Uh oh!

sendaoYan commented Jan 31, 2025

Uh oh!

openjdk bot commented Jan 31, 2025

Uh oh!

openjdk bot commented Jan 31, 2025

Uh oh!

sendaoYan commented Feb 25, 2025

Uh oh!

openjdk bot commented Feb 25, 2025

Uh oh!

sendaoYan commented Feb 25, 2025

Uh oh!

openjdk bot commented Feb 25, 2025

Uh oh!

zzambers commented Feb 25, 2025

Uh oh!

openjdk bot commented Feb 25, 2025

Uh oh!

openjdk bot commented Feb 25, 2025

Uh oh!

sendaoYan commented Feb 25, 2025

Uh oh!

Uh oh!

sendaoYan commented Jul 30, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jul 30, 2024 •

edited

Loading